Fix checksum files being overwritten by windows release (#1086)

* fix checksum files being overwritten by windows release

* add changelog entry

* adjust changelog entry

* adjust changelog entry

* adjust changelog entry

Author: mowies

.chloggen/mowies-fix-checksums.yaml

@@ -0,0 +1,31 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: breaking
+
+# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
+component: releases
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Fix artifact checksum files being incomplete and split between Linux/Darwin and Windows.
+
+# One or more tracking issues or pull requests related to the change
+issues: [1002, 1086]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext: |
+  This fixes a bug that occurred because releases for Windows and other Platforms are split.
+  The Windows release always overwrote the checksum files already created for Linux and Darwin and so, only
+  the Windows checksums were accessible in the end.
+  
+  This change is breaking because checksum files for Linux/Darwin and Windows are now split.
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: []
+

cmd/goreleaser/internal/configure.go

@@ -354,7 +354,7 @@ func (b *distributionBuilder) sboms() []config.SBOM {
 func (b *distributionBuilder) WithDefaultChecksum() *distributionBuilder {
 	b.configFuncs = append(b.configFuncs, func(d *distribution) {
 		b.dist.checksum = config.Checksum{
-			NameTemplate: fmt.Sprintf("{{ .ProjectName }}_%v_checksums.txt", d.name),
+			NameTemplate: fmt.Sprintf("{{ .ProjectName }}_%v{{ if .Runtime.Goos == \"windows\" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt", d.name),
 		}
 	})
 	return b

distributions/otelcol-contrib/.goreleaser.yaml

@@ -103,7 +103,7 @@ nfpms:
     builds:
       - otelcol-contrib-linux
 checksum:
-  name_template: '{{ .ProjectName }}_otelcol-contrib_checksums.txt'
+  name_template: '{{ .ProjectName }}_otelcol-contrib{{ if .Runtime.Goos == "windows" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt'
 dockers:
   - goos: linux
     goarch: "386"

distributions/otelcol-ebpf-profiler/.goreleaser.yaml

@@ -26,7 +26,7 @@ archives:
     builds:
       - otelcol-ebpf-profiler-linux
 checksum:
-  name_template: '{{ .ProjectName }}_otelcol-ebpf-profiler_checksums.txt'
+  name_template: '{{ .ProjectName }}_otelcol-ebpf-profiler{{ if .Runtime.Goos == "windows" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt'
 dockers:
   - goos: linux
     goarch: amd64

distributions/otelcol-k8s/.goreleaser.yaml

@@ -44,7 +44,7 @@ archives:
       - otelcol-k8s-linux
       - otelcol-k8s-windows
 checksum:
-  name_template: '{{ .ProjectName }}_otelcol-k8s_checksums.txt'
+  name_template: '{{ .ProjectName }}_otelcol-k8s{{ if .Runtime.Goos == "windows" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt'
 dockers:
   - goos: linux
     goarch: amd64

distributions/otelcol-otlp/.goreleaser.yaml

@@ -94,7 +94,7 @@ nfpms:
     builds:
       - otelcol-otlp-linux
 checksum:
-  name_template: '{{ .ProjectName }}_otelcol-otlp_checksums.txt'
+  name_template: '{{ .ProjectName }}_otelcol-otlp{{ if .Runtime.Goos == "windows" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt'
 dockers:
   - goos: linux
     goarch: "386"

distributions/otelcol/.goreleaser.yaml

@@ -98,7 +98,7 @@ nfpms:
     builds:
       - otelcol-linux
 checksum:
-  name_template: '{{ .ProjectName }}_otelcol_checksums.txt'
+  name_template: '{{ .ProjectName }}_otelcol{{ if .Runtime.Goos == "windows" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt'
 dockers:
   - goos: linux
     goarch: "386"