service: Reject duplicate component IDs in configuration

Author: Arunodoy18

.chloggen/fix-duplicate-component-ids.yaml

@@ -0,0 +1,4 @@
+change_type: bug_fix
+component: service
+note: Reject configuration with duplicate component IDs in extensions, receivers, and exporters lists.
+issues: [13912]

service/extensions/config.go

@@ -3,7 +3,24 @@
 
 package extensions // import "go.opentelemetry.io/collector/service/extensions"
 
-import "go.opentelemetry.io/collector/component"
+import (
+	"fmt"
+
+	"go.opentelemetry.io/collector/component"
+)
 
 // Config represents the ordered list of extensions configured for the service.
 type Config []component.ID
+
+// Validate checks if the configuration is valid.
+func (cfg Config) Validate() error {
+	// Validate no extensions are duplicated.
+	extSet := make(map[component.ID]struct{}, len(cfg))
+	for _, ref := range cfg {
+		if _, exists := extSet[ref]; exists {
+			return fmt.Errorf("references extension %q multiple times", ref)
+		}
+		extSet[ref] = struct{}{}
+	}
+	return nil
+}

service/extensions/config_test.go

@@ -0,0 +1,43 @@
+// Copyright The OpenTelemetry Authors
+// SPDX-License-Identifier: Apache-2.0
+
+package extensions
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	"go.opentelemetry.io/collector/component"
+	"go.opentelemetry.io/collector/confmap/xconfmap"
+)
+
+func TestConfigValidate(t *testing.T) {
+	testCases := []struct {
+		name     string
+		cfg      Config
+		expected error
+	}{
+		{
+			name:     "valid",
+			cfg:      Config{component.MustNewID("nop")},
+			expected: nil,
+		},
+		{
+			name:     "duplicate-extension-reference",
+			cfg:      Config{component.MustNewID("nop"), component.MustNewID("nop")},
+			expected: errors.New(`references extension "nop" multiple times`),
+		},
+	}
+
+	for _, tt := range testCases {
+		t.Run(tt.name, func(t *testing.T) {
+			if tt.expected != nil {
+				require.ErrorContains(t, xconfmap.Validate(tt.cfg), tt.expected.Error())
+			} else {
+				require.NoError(t, xconfmap.Validate(tt.cfg))
+			}
+		})
+	}
+}

service/pipelines/config.go

@@ -77,6 +77,15 @@ func (cfg *PipelineConfig) Validate() error {
 		return errMissingServicePipelineExporters
 	}
 
+	// Validate no receivers are duplicated within a pipeline.
+	recvSet := make(map[component.ID]struct{}, len(cfg.Receivers))
+	for _, ref := range cfg.Receivers {
+		if _, exists := recvSet[ref]; exists {
+			return fmt.Errorf("references receiver %q multiple times", ref)
+		}
+		recvSet[ref] = struct{}{}
+	}
+
 	// Validate no processors are duplicated within a pipeline.
 	procSet := make(map[component.ID]struct{}, len(cfg.Processors))
 	for _, ref := range cfg.Processors {
@@ -87,5 +96,14 @@ func (cfg *PipelineConfig) Validate() error {
 		procSet[ref] = struct{}{}
 	}
 
+	// Validate no exporters are duplicated within a pipeline.
+	expSet := make(map[component.ID]struct{}, len(cfg.Exporters))
+	for _, ref := range cfg.Exporters {
+		if _, exists := expSet[ref]; exists {
+			return fmt.Errorf("references exporter %q multiple times", ref)
+		}
+		expSet[ref] = struct{}{}
+	}
+
 	return nil
 }

service/pipelines/config_test.go

@@ -37,6 +37,26 @@ func TestConfigValidate(t *testing.T) {
 			},
 			expected: errors.New(`references processor "nop" multiple times`),
 		},
+		{
+			name: "duplicate-receiver-reference",
+			cfgFn: func(*testing.T) Config {
+				cfg := generateConfig(t)
+				pipe := cfg[pipeline.NewID(pipeline.SignalTraces)]
+				pipe.Receivers = append(pipe.Receivers, pipe.Receivers...)
+				return cfg
+			},
+			expected: errors.New(`references receiver "nop" multiple times`),
+		},
+		{
+			name: "duplicate-exporter-reference",
+			cfgFn: func(*testing.T) Config {
+				cfg := generateConfig(t)
+				pipe := cfg[pipeline.NewID(pipeline.SignalTraces)]
+				pipe.Exporters = append(pipe.Exporters, pipe.Exporters...)
+				return cfg
+			},
+			expected: errors.New(`references exporter "nop" multiple times`),
+		},
 		{
 			name: "missing-pipeline-receivers",
 			cfgFn: func(*testing.T) Config {