Skip to content

Commit 70644ec

Browse files
committed
cmd/builder: clarify CLI error handling and update changelog
1 parent eeb43e7 commit 70644ec

File tree

2 files changed

+27
-0
lines changed

2 files changed

+27
-0
lines changed
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: enhancement
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. receiver/otlp)
7+
component: cmd/builder
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Avoid duplicate CLI error logging in generated collector binaries by relying on cobra's error handling.
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [14317]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: []

cmd/builder/internal/builder/templates/main.go.tmpl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ func main() {
5959
}
6060

6161
if err := run(set); err != nil {
62+
// The error message is logged by cobra, so we intentionally
63+
// avoid logging it again here to prevent duplicate output.
6264
os.Exit(1)
6365
}
6466
}

0 commit comments

Comments
 (0)