Skip to content

Commit 7d965e1

Browse files
authored
[chore] Remove unneccessary empty lines from generated code (#14337)
Depends on #14333 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
1 parent 45c4476 commit 7d965e1

File tree

68 files changed

+138
-245
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+138
-245
lines changed

internal/cmd/pdatagen/internal/pdata/one_of_field.go

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ func (ms {{ .structName }}) {{ .typeFuncName }}() {{ .typeName }} {
2121
return {{ .typeName }}Empty
2222
}
2323
24-
{{ range .values }}
24+
{{ range .values -}}
2525
{{ .GenerateAccessors $.baseStruct $.OneOfField }}
26-
{{ end }}`
26+
{{- end }}`
2727

2828
const oneOfAccessorTestTemplate = `func Test{{ .structName }}_{{ .typeFuncName }}(t *testing.T) {
2929
tv := New{{ .structName }}()
@@ -32,21 +32,21 @@ const oneOfAccessorTestTemplate = `func Test{{ .structName }}_{{ .typeFuncName }
3232
3333
{{ range .values -}}
3434
{{ .GenerateTests $.baseStruct $.OneOfField }}
35-
{{ end }}
35+
{{- end }}
3636
`
3737

3838
const oneOfTestFailingUnmarshalProtoValuesTemplate = `
39-
{{- range .fields }}
39+
{{ range .fields -}}
4040
{{ .GenTestFailingUnmarshalProtoValues }}
4141
{{- end }}`
4242

4343
const oneOfTestValuesTemplate = `
44-
{{- range .fields }}
44+
{{ range .fields -}}
4545
{{ .GenTestEncodingValues }}
4646
{{- end }}`
4747

4848
const oneOfPoolOrigTemplate = `
49-
{{- range .fields }}
49+
{{ range .fields -}}
5050
{{ .GenPool }}
5151
{{- end }}`
5252

@@ -58,36 +58,36 @@ func (m *{{ .protoName }}) Get{{ .originFieldName }}() any {
5858
return nil
5959
}
6060
61-
{{- range .fields }}
61+
{{ range .fields -}}
6262
{{ .GenOneOfMessages }}
6363
{{- end }}`
6464

6565
const oneOfDeleteOrigTemplate = `switch ov := orig.{{ .originFieldName }}.(type) {
6666
{{ range .fields -}}
6767
case *{{ $.protoName }}_{{ .GetName }}:
68-
{{ .GenDelete }}{{- end }}
69-
}
70-
`
68+
{{ .GenDelete }}
69+
{{ end -}}
70+
}`
7171

7272
const oneOfCopyOrigTemplate = `switch t := src.{{ .originFieldName }}.(type) {
73-
{{- range .fields }}
73+
{{ range .fields -}}
7474
case *{{ $.protoName }}_{{ .GetName }}:
7575
{{ .GenCopy }}
76-
{{- end }}
76+
{{ end -}}
7777
default:
7878
dest.{{ .originFieldName }} = nil
7979
}`
8080

8181
const oneOfMarshalJSONTemplate = `switch orig := orig.{{ .originFieldName }}.(type) {
82-
{{- range .fields }}
82+
{{ range .fields -}}
8383
case *{{ $.protoName }}_{{ .GetName }}:
8484
{{ .GenMarshalJSON }}
85-
{{- end }}
85+
{{ end -}}
8686
}`
8787

8888
const oneOfUnmarshalJSONTemplate = `
89-
{{- range .fields }}
90-
{{ .GenUnmarshalJSON }}
89+
{{ range .fields -}}
90+
{{ .GenUnmarshalJSON }}
9191
{{- end }}`
9292

9393
const oneOfSizeProtoTemplate = `switch orig := orig.{{ .originFieldName }}.(type) {
@@ -101,16 +101,16 @@ const oneOfSizeProtoTemplate = `switch orig := orig.{{ .originFieldName }}.(type
101101
}`
102102

103103
const oneOfMarshalProtoTemplate = `switch orig := orig.{{ .originFieldName }}.(type) {
104-
{{- range .fields }}
104+
{{ range .fields -}}
105105
case *{{ $.protoName }}_{{ .GetName }}:
106106
{{ .GenMarshalProto }}
107-
{{- end }}
107+
{{ end -}}
108108
}`
109109

110110
const oneOfUnmarshalProtoTemplate = `
111111
{{- range .fields }}
112112
{{ .GenUnmarshalProto }}
113-
{{- end }}`
113+
{{ end }}`
114114

115115
type OneOfField struct {
116116
originFieldName string

internal/cmd/pdatagen/internal/proto/delete.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ const deleteOther = `{{ if ne .oneOfGroup "" -}}
1212
ov.{{ .fieldName }} = {{ .defaultValue }}
1313
ProtoPool{{ .oneOfMessageName }}.Put(ov)
1414
}
15-
{{ end }}`
15+
{{- end -}}`
1616

1717
const deleteMessage = `{{ if .repeated -}}
1818
for i := range orig.{{ .fieldName }} {
1919
{{ if .nullable -}}
2020
Delete{{ .messageName }}(orig.{{ .fieldName }}[i], true)
21-
{{- else -}}
21+
{{ else -}}
2222
Delete{{ .messageName }}(&orig.{{ .fieldName }}[i], false)
23-
{{- end }}
23+
{{- end -}}
2424
}
2525
{{- else if ne .oneOfGroup "" -}}
2626
Delete{{ .messageName }}(ov.{{ .fieldName }}, true)
@@ -30,7 +30,7 @@ const deleteMessage = `{{ if .repeated -}}
3030
Delete{{ .messageName }}(orig.{{ .fieldName }}, true)
3131
{{- else -}}
3232
Delete{{ .messageName }}(&orig.{{ .fieldName }}, false)
33-
{{- end }}
33+
{{- end -}}
3434
`
3535

3636
func (pf *Field) GenDelete() string {

internal/cmd/pdatagen/internal/proto/proto_size.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ const sizeProtoI8 = `{{ if .repeated -}}
1515
l *= 8
1616
n+= {{ .protoTagSize }} + proto.Sov(uint64(l)) + l
1717
}
18-
{{- else if ne .oneOfGroup "" -}}
18+
{{- else if ne .oneOfGroup "" }}
1919
n+= {{ add .protoTagSize 8 }}
20-
{{- else -}}
20+
{{- else }}
2121
{{- if not .nullable -}}
2222
if orig.{{ .fieldName }} != {{ .defaultValue }} {
2323
{{- else -}}
@@ -33,9 +33,9 @@ const sizeProtoI4 = `{{ if .repeated -}}
3333
l *= 4
3434
n+= + {{ .protoTagSize }} + proto.Sov(uint64(l)) + l
3535
}
36-
{{- else if ne .oneOfGroup "" -}}
36+
{{- else if ne .oneOfGroup "" }}
3737
n+= {{ add .protoTagSize 4 }}
38-
{{- else -}}
38+
{{- else }}
3939
{{- if not .nullable -}}
4040
if orig.{{ .fieldName }} != {{ .defaultValue }} {
4141
{{- else -}}
@@ -50,7 +50,7 @@ const sizeProtoBool = `{{ if .repeated -}}
5050
if l > 0 {
5151
n+= + {{ .protoTagSize }} + proto.Sov(uint64(l)) + l
5252
}
53-
{{- else if ne .oneOfGroup "" -}}
53+
{{- else if ne .oneOfGroup "" }}
5454
n+= {{ add .protoTagSize 1 }}
5555
{{- else -}}
5656
{{- if not .nullable -}}
@@ -62,17 +62,17 @@ const sizeProtoBool = `{{ if .repeated -}}
6262
}
6363
{{- end }}`
6464

65-
const sizeProtoVarint = `{{ if .repeated -}}
65+
const sizeProtoVarint = `{{ if .repeated }}
6666
if len(orig.{{ .fieldName }}) > 0 {
6767
l = 0
6868
for _, e := range orig.{{ .fieldName }} {
6969
l += proto.Sov(uint64(e))
7070
}
7171
n+= {{ .protoTagSize }} + proto.Sov(uint64(l)) + l
7272
}
73-
{{- else if ne .oneOfGroup "" -}}
73+
{{- else if ne .oneOfGroup "" }}
7474
n+= {{ .protoTagSize }} + proto.Sov(uint64(orig.{{ .fieldName }}))
75-
{{- else -}}
75+
{{- else }}
7676
{{- if not .nullable -}}
7777
if orig.{{ .fieldName }} != {{ .defaultValue }} {
7878
{{- else -}}

internal/cmd/pdatagen/internal/proto/templates/message.go.tmpl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,9 @@ func Delete{{ .messageName }}(orig *{{ .messageName }}, nullable bool) {
5353
return
5454
}
5555

56-
{{ range .fields }}{{ .GenDelete }}{{ end }}
56+
{{- range .fields }}
57+
{{ .GenDelete }}
58+
{{- end }}
5759
orig.Reset()
5860
if nullable {
5961
protoPool{{ .messageName }}.Put(orig)

pdata/internal/generated_proto_anyvalue.go

Lines changed: 4 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pdata/internal/generated_proto_anyvalue_test.go

Lines changed: 15 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pdata/internal/generated_proto_arrayvalue.go

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pdata/internal/generated_proto_exemplar.go

Lines changed: 3 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)