Add support for SOAP-headers in OpenTelemetry.Instrumentation.AspNet (ActivityHelper)

[olahallvall]

Feature Request

The library OpenTelemetry.Instrumentation.AspNet can today only extract headers from ordinary http headers.
I would like to extend this library to support SOAP-headers as well.

SOAP-header are not in the same place as ordinary http headers. Please see below:

  <?xml version="1.0"?>
  <soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope/"
  soap:encodingStyle="http://www.w3.org/2003/05/soap-encoding">
  
  <soap:Header>
     <traceparent>00-392035ad9a5bc44b94715b99673d14f8-d8ca005e5d95554c-01</traceparent>
  </soap:Header>
  
  <soap:Body>
  ...
    <soap:Fault>
    ...
    </soap:Fault>
  </soap:Body>
  
  </soap:Envelope>

By extend the ActivityHelper class in OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule the library can support both types of headers.

My customer has a big number of ASMX-services that we would like to have tracing support.

I have made a working prototyp here that works!
I would like to contribute my solution to the OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule component.

Can a buddy help me start up the contribution?

[En3Tho]

@olahallvall Hi, Ola! I have the same requirement. Old service, sync, bugs, sadness. Have you solved this problem? If yes, is the prototype you've shared the final solution? Or did you add something more like maybe there were edge cases and things like that?

[olahallvall]

Hi Igor, I used the code in my prototype for production. Can't remember if needed to fix i bug or not!

[En3Tho]

@olahallvall Thank you

[epicdigitalacademy]

Hi olahallvall,

Are you using this in production and is it working well with SOAP built on .NET core ? Am surprise I cant find anything on SOAP for opentelemetry on the internet

[olahallvall]

Hi, sorry but I was not able to make a contribution with my code.

I have used a similar solution like this code and it works good. Have not run this code in .net core yet.

[epicdigitalacademy]

thanks @olahallvall for providing feedback. Am hoping will provide direction. We have a couple SOAP services and opentelemetry is not able to pick the SOAP headers and so the monitoring is useless as you cannot distinguish requests.