Skip to content

[bug] OpenTelemetry.Instrumentation.EntityFrameworkCore v1.0.0-beta.10 - Devart.Data.Oracle is missing db.statement tag and has wrong db.system value #2462

@vladajankovic

Description

Component

OpenTelemetry.Instrumentation.EntityFrameworkCore

Package Version

Package Name Version
OpenTelemetry.Api 1.9.0
OpenTelemetry 1.8.1
TBD TBD

Runtime Version

net8.0

Description

Package versions:

  • Devart.Data.Oracle v10.3.104
  • Devart.Data.Oracle.EFCore v10.3.105.8
  • OpenTelemetry.Instrumentation.EntityFrameworkCore v1.0.0-beta.10

The providerName for Devart.Data.Oracle is "Devart.Data.Oracle.Entity.EFCore", and not "Devart.Data.Oracle.EFCore", which misses the correct switch case and executes the default case db.system="other_sql" Source Code

Also, an exception is thrown on this line when Fetchers are used in a specific case when the command is CommandType.Text, and the db.statement is not set.

Steps to Reproduce

Use these package versions:

  • Devart.Data.Oracle v10.3.104
  • Devart.Data.Oracle.EFCore v10.3.105.8
  • OpenTelemetry.Instrumentation.EntityFrameworkCore v1.0.0-beta.10

Expected Result

Activity class to have tags db.system="oracle" and db.statement that contains the sql statement

Actual Result

Activity class has tag db.system="other_sql" and the db.statement tag is missing

Additional Context

No response

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcomp:instrumentation.entityframeworkcoreThings related to OpenTelemetry.Instrumentation.EntityFrameworkCore

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions