Enable Roslyn analysis - others - part 1

Author: Kielek

examples/demo/Client/Examples.Client.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
 

examples/demo/Client/Program.cs

@@ -5,7 +5,9 @@
 //     dotnet run http://localhost:5200
 if (args.Length != 1)
 {
-    Console.WriteLine(@"URL missing");
+#pragma warning disable CA1303 // Do not pass literals as localized parameters
+    Console.WriteLine("URL missing");
+#pragma warning restore CA1303 // Do not pass literals as localized parameters
     return 2;
 }
 
@@ -15,13 +17,13 @@
 {
     try
     {
-        var content = await httpClient.GetStringAsync(url);
+        var content = await httpClient.GetStringAsync(new Uri(url)).ConfigureAwait(false);
         Console.WriteLine(content);
     }
     catch (HttpRequestException ex)
     {
         Console.WriteLine(ex.Message);
     }
 
-    Thread.Sleep(5000);
+    await Task.Delay(5000).ConfigureAwait(false);
 }

examples/demo/Service/Examples.Service.csproj

@@ -1,13 +1,12 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Data.SqlClient" />
-    <PackageReference Include="Microsoft.Extensions.Logging" />
   </ItemGroup>
 
 </Project>

examples/demo/Service/Program.cs

@@ -20,17 +20,17 @@
 
 async Task<string> Handler(ILogger<Program> logger)
 {
-    await ExecuteSql("SELECT 1");
+    await ExecuteSql("SELECT 1").ConfigureAwait(false);
 
     // .NET Diagnostics: create a manual span
     using (var activity = activitySource.StartActivity("SayHello"))
     {
         activity?.SetTag("foo", 1);
         activity?.SetTag("bar", "Hello, World!");
-        activity?.SetTag("baz", new int[] { 1, 2, 3 });
+        activity?.SetTag("baz", (int[])[1, 2, 3]);
 
         var waitTime = Random.Shared.NextDouble(); // max 1 seconds
-        await Task.Delay(TimeSpan.FromSeconds(waitTime));
+        await Task.Delay(TimeSpan.FromSeconds(waitTime)).ConfigureAwait(false);
 
         activity?.SetStatus(ActivityStatusCode.Ok);
 
@@ -47,7 +47,9 @@ async Task<string> Handler(ILogger<Program> logger)
 async Task ExecuteSql(string sql)
 {
     using var connection = new SqlConnection(connectionString);
-    await connection.OpenAsync();
+    await connection.OpenAsync().ConfigureAwait(false);
+#pragma warning disable CA2100 // Review SQL queries for security vulnerabilities. It is static SQL for demo purposes.
     using var command = new SqlCommand(sql, connection);
-    using var reader = await command.ExecuteReaderAsync();
+#pragma warning restore CA2100 // Review SQL queries for security vulnerabilities. It is static SQL for demo purposes.
+    using var reader = await command.ExecuteReaderAsync().ConfigureAwait(false);
 }

examples/playground/AspNetCoreMvc/Controllers/ApiController.cs

@@ -20,7 +20,7 @@ public ActionResult Delay(int seconds)
     [Route("delay-async/{seconds}")]
     public async Task<ActionResult> DelayAsync(int seconds)
     {
-        await Task.Delay(TimeSpan.FromSeconds(seconds));
+        await Task.Delay(TimeSpan.FromSeconds(seconds)).ConfigureAwait(false);
         return Ok(seconds);
     }
 }

examples/playground/AspNetCoreMvc/Controllers/HomeController.cs

@@ -22,7 +22,7 @@ public IActionResult Index()
                       from prefix in prefixes
                       let key = (envVar.Key as string)?.ToUpperInvariant()
                       let value = envVar.Value as string
-                      where key.StartsWith(prefix)
+                      where key.StartsWith(prefix, StringComparison.Ordinal)
                       orderby key
                       select new KeyValuePair<string, string>(key, value);
 
@@ -41,14 +41,14 @@ public IActionResult Delay(int seconds)
     public async Task<IActionResult> DelayAsync(int seconds)
     {
         ViewBag.StackTrace = StackTraceHelper.GetUsefulStack();
-        await Task.Delay(TimeSpan.FromSeconds(seconds));
+        await Task.Delay(TimeSpan.FromSeconds(seconds)).ConfigureAwait(false);
         return View("Delay", seconds);
     }
 
     [Route("bad-request")]
     public IActionResult ThrowException()
     {
-        throw new Exception("This was a bad request.");
+        throw new InvalidOperationException("This was a bad request.");
     }
 
     [Route("status-code/{statusCode}")]

examples/playground/AspNetCoreMvc/Examples.AspNetCoreMvc.csproj

@@ -3,6 +3,8 @@
   <PropertyGroup>
     <TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks>
     <RootNamespace>Examples.AspNetCoreMvc</RootNamespace>
+    <!-- CA1515: Consider making public types internal. Controllers needs to be public. -->
+    <NoWarn>$(NoWarn);CA1515</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

examples/playground/AspNetCoreMvc/OtelSdkPlugin.cs

@@ -7,6 +7,8 @@ public class OtelSdkPlugin
 {
     public void Initializing()
     {
+#pragma warning disable CA1303 // Do not pass literals as localized parameters
         Console.WriteLine("Hello from OtelSdkPlugin");
+#pragma warning restore CA1303 // Do not pass literals as localized parameters
     }
 }

examples/playground/AspNetCoreMvc/Program.cs

@@ -3,7 +3,7 @@
 
 namespace Examples.AspNetCoreMvc;
 
-public class Program
+internal static class Program
 {
     public static void Main(string[] args)
     {

examples/playground/AspNetCoreMvc/Shared/StackTraceHelper.cs

@@ -3,12 +3,12 @@
 
 namespace Examples.AspNetCoreMvc.Shared;
 
-public static class StackTraceHelper
+internal static class StackTraceHelper
 {
     public static string[] GetUsefulStack()
     {
         var stackTrace = Environment.StackTrace;
-        string[] methods = stackTrace.Split(new[] { " at " }, StringSplitOptions.None);
+        var methods = stackTrace.Split([" at "], StringSplitOptions.None);
         return methods;
     }
 }