Enable Roslyn analysis - main project - part I (#4685)

* CA1813

* CA1859

* CA1813

* CA2263

* CA2201

* CA1305

* CA1508

* CA1307

* CA1309

* CA1805

* CA1806

* CA1310

* CA1019

* CA1308

Author: Kielek

src/OpenTelemetry.AutoInstrumentation/AutoInstrumentationVersion.cs

@@ -26,7 +26,11 @@ private static string GetAssemblyInformationalVersion()
             // The following parts are optional: pre-release label, pre-release version, git height, Git SHA of current commit
             // for example: 1.5.0-alpha.1.40+807f703e1b4d9874a92bd86d9f2d4ebe5b5d52e4
 
+#if NET
+            var indexOfPlusSign = informationalVersion.IndexOf('+', StringComparison.Ordinal);
+#else
             var indexOfPlusSign = informationalVersion.IndexOf('+');
+#endif
             return indexOfPlusSign > 0 ? informationalVersion.Substring(0, indexOfPlusSign) : informationalVersion;
         }
         catch (Exception)

src/OpenTelemetry.AutoInstrumentation/CallTarget/Handlers/IntegrationOptions.cs

@@ -12,7 +12,7 @@ internal static class IntegrationOptions<TIntegration, TTarget>
 {
     private static readonly IOtelLogger Log = OtelLogging.GetLogger();
 
-    private static volatile bool _disableIntegration = false;
+    private static volatile bool _disableIntegration;
 
     internal static bool IsIntegrationEnabled => !_disableIntegration;
 
@@ -36,7 +36,7 @@ internal static void LogException(Exception exception, string? message = null)
         }
         else if (exception is FileLoadException fileLoadException)
         {
-            if (fileLoadException.FileName != null && (fileLoadException.FileName.StartsWith("System.Diagnostics.DiagnosticSource") || fileLoadException.FileName.StartsWith("System.Runtime.CompilerServices.Unsafe")))
+            if (fileLoadException.FileName != null && (fileLoadException.FileName.StartsWith("System.Diagnostics.DiagnosticSource", StringComparison.Ordinal) || fileLoadException.FileName.StartsWith("System.Runtime.CompilerServices.Unsafe", StringComparison.Ordinal)))
             {
                 Log.Warning($"FileLoadException for '{fileLoadException.FileName}' has been detected, the integration <{typeof(TIntegration)}, {typeof(TTarget)}> will be disabled.");
                 _disableIntegration = true;

src/OpenTelemetry.AutoInstrumentation/CallTarget/PreserveContextAttribute.cs

@@ -8,6 +8,6 @@ namespace OpenTelemetry.AutoInstrumentation.CallTarget;
 /// should execute under the current synchronization context/task scheduler.
 /// </summary>
 [AttributeUsage(AttributeTargets.Method)]
-internal class PreserveContextAttribute : Attribute
+internal sealed class PreserveContextAttribute : Attribute
 {
 }

src/OpenTelemetry.AutoInstrumentation/Configurations/ConfigurationExtensions.cs

@@ -10,7 +10,11 @@ internal static class ConfigurationExtensions
     public static IReadOnlyList<TEnum> ParseEnabledEnumList<TEnum>(this Configuration source, bool enabledByDefault, string enabledConfigurationTemplate)
         where TEnum : struct, Enum, IConvertible
     {
+#if NET
+        var allConfigurations = Enum.GetValues<TEnum>();
+#else
         var allConfigurations = Enum.GetValues(typeof(TEnum)).Cast<TEnum>().ToArray();
+#endif
         var enabledConfigurations = new List<TEnum>(allConfigurations.Length);
 
         foreach (var configuration in allConfigurations)

src/OpenTelemetry.AutoInstrumentation/Configurations/DelayedInitialization.cs

@@ -16,7 +16,7 @@ internal static class Traces
         [MethodImpl(MethodImplOptions.NoInlining)]
         public static void AddAspNet(LazyInstrumentationLoader lazyInstrumentationLoader, PluginManager pluginManager, TracerSettings tracerSettings)
         {
-            new AspNetInitializer(lazyInstrumentationLoader, pluginManager, tracerSettings);
+            _ = new AspNetInitializer(lazyInstrumentationLoader, pluginManager, tracerSettings);
         }
 #endif
 
@@ -31,7 +31,7 @@ public static void AddAspNetCore(LazyInstrumentationLoader lazyInstrumentationLo
         [MethodImpl(MethodImplOptions.NoInlining)]
         public static void AddHttpClient(LazyInstrumentationLoader lazyInstrumentationLoader, PluginManager pluginManager, TracerSettings tracerSettings)
         {
-            new HttpClientInitializer(lazyInstrumentationLoader, pluginManager, tracerSettings);
+            _ = new HttpClientInitializer(lazyInstrumentationLoader, pluginManager, tracerSettings);
         }
 
         [MethodImpl(MethodImplOptions.NoInlining)]
@@ -43,7 +43,7 @@ public static void AddGrpcClient(LazyInstrumentationLoader lazyInstrumentationLo
         [MethodImpl(MethodImplOptions.NoInlining)]
         public static void AddSqlClient(LazyInstrumentationLoader lazyInstrumentationLoader, PluginManager pluginManager)
         {
-            new SqlClientTracerInitializer(lazyInstrumentationLoader, pluginManager);
+            _ = new SqlClientTracerInitializer(lazyInstrumentationLoader, pluginManager);
         }
 
 #if NET
@@ -80,20 +80,20 @@ internal static class Metrics
         [MethodImpl(MethodImplOptions.NoInlining)]
         public static void AddAspNet(LazyInstrumentationLoader lazyInstrumentationLoader, PluginManager pluginManager)
         {
-            new AspNetMetricsInitializer(lazyInstrumentationLoader, pluginManager);
+            _ = new AspNetMetricsInitializer(lazyInstrumentationLoader, pluginManager);
         }
 #endif
 
         [MethodImpl(MethodImplOptions.NoInlining)]
         public static void AddHttpClient(LazyInstrumentationLoader lazyInstrumentationLoader)
         {
-            new HttpClientMetricsInitializer(lazyInstrumentationLoader);
+            _ = new HttpClientMetricsInitializer(lazyInstrumentationLoader);
         }
 
         [MethodImpl(MethodImplOptions.NoInlining)]
         public static void AddSqlClient(LazyInstrumentationLoader lazyInstrumentationLoader, PluginManager pluginManager)
         {
-            new SqlClientMetricsInitializer(lazyInstrumentationLoader, pluginManager);
+            _ = new SqlClientMetricsInitializer(lazyInstrumentationLoader, pluginManager);
         }
     }
 }

src/OpenTelemetry.AutoInstrumentation/Configurations/EnvironmentInitializer.cs

@@ -22,7 +22,7 @@ public static void Initialize(NameValueCollection nameValueCollection)
                 continue;
             }
 
-            if (!setting.StartsWith(VariablePrefix))
+            if (!setting.StartsWith(VariablePrefix, StringComparison.Ordinal))
             {
                 // not OTEL_ setting
                 continue;

src/OpenTelemetry.AutoInstrumentation/Configurations/FileBasedConfiguration/Parser/ConditionalDeserializer.cs

@@ -23,7 +23,7 @@ public bool Deserialize(
          out object? value,
          ObjectDeserializer rootDeserializer)
     {
-        var isEmptyObjectOnEmptyYamlAttribute = expectedType.CustomAttributes.Any(a => string.Equals(a.AttributeType.Name, "EmptyObjectOnEmptyYamlAttribute", StringComparison.InvariantCulture));
+        var isEmptyObjectOnEmptyYamlAttribute = expectedType.CustomAttributes.Any(a => string.Equals(a.AttributeType.Name, "EmptyObjectOnEmptyYamlAttribute", StringComparison.Ordinal));
 
         if (!isEmptyObjectOnEmptyYamlAttribute)
         {

src/OpenTelemetry.AutoInstrumentation/Configurations/FileBasedConfiguration/Parser/EnvVarTypeConverter.cs

@@ -55,14 +55,14 @@ public bool Accepts(Type type)
             return type switch
             {
                 Type t when t == typeof(string) => replacedValue,
-                Type t when t == typeof(int) => int.Parse(replacedValue),
-                Type t when t == typeof(uint) => uint.Parse(replacedValue),
-                Type t when t == typeof(long) => long.Parse(replacedValue),
+                Type t when t == typeof(int) => int.Parse(replacedValue, CultureInfo.InvariantCulture),
+                Type t when t == typeof(uint) => uint.Parse(replacedValue, CultureInfo.InvariantCulture),
+                Type t when t == typeof(long) => long.Parse(replacedValue, CultureInfo.InvariantCulture),
                 Type t when t == typeof(float) => float.Parse(replacedValue, CultureInfo.InvariantCulture),
                 Type t when t == typeof(double) => double.Parse(replacedValue, CultureInfo.InvariantCulture),
                 Type t when t == typeof(bool) => bool.Parse(replacedValue),
-                Type t when t == typeof(int?) => int.Parse(replacedValue),
-                Type t when t == typeof(uint?) => uint.Parse(replacedValue),
+                Type t when t == typeof(int?) => int.Parse(replacedValue, CultureInfo.InvariantCulture),
+                Type t when t == typeof(uint?) => uint.Parse(replacedValue, CultureInfo.InvariantCulture),
                 Type t when t == typeof(object) => replacedValue,
                 _ => throw new NotSupportedException($"Type {type.FullName} is not supported by the converter")
             };

src/OpenTelemetry.AutoInstrumentation/Configurations/FileBasedConfiguration/SamplerFactory.cs

@@ -94,7 +94,7 @@ internal static class SamplerFactory
         return configuredSampler;
     }
 
-    private static Sampler? CreateTraceIdRatioSampler(TraceIdRatioSamplerConfig config, bool failFast, string path)
+    private static TraceIdRatioBasedSampler? CreateTraceIdRatioSampler(TraceIdRatioSamplerConfig config, bool failFast, string path)
     {
         if (!config.Ratio.HasValue)
         {
@@ -126,7 +126,7 @@ internal static class SamplerFactory
         return new TraceIdRatioBasedSampler(ratio);
     }
 
-    private static Sampler CreateParentBasedSampler(ParentBasedSamplerConfig config, bool failFast, string path)
+    private static ParentBasedSampler CreateParentBasedSampler(ParentBasedSamplerConfig config, bool failFast, string path)
     {
         var rootSampler = GetSamplerOrDefault(config.Root, new AlwaysOnSampler(), failFast, path + ".root", "always_on");
         var remoteParentSampled = GetSamplerOrDefault(config.RemoteParentSampled, new AlwaysOnSampler(), failFast, path + ".remote_parent_sampled", "always_on");

src/OpenTelemetry.AutoInstrumentation/Configurations/IntegrationRegistry.cs

@@ -11,7 +11,11 @@ internal static class IntegrationRegistry
 
     static IntegrationRegistry()
     {
+#if NET
+        var values = Enum.GetValues<TracerInstrumentation>();
+#else
         var values = Enum.GetValues(typeof(TracerInstrumentation));
+#endif
         var ids = new Dictionary<string, int>(values.Length);
 
         Names = new string[values.Cast<int>().Max() + 1];