Enable Roslyn analysis - Test Applicatiosn - part I

Author: Kielek

test/OpenTelemetry.AutoInstrumentation.Native.Tests/clr_helper_test.cpp

@@ -106,8 +106,10 @@ TEST_F(CLRHelperTest, GetsTypeInfoFromTypeDefs)
 
 TEST_F(CLRHelperTest, GetsTypeInfoFromTypeRefs)
 {
-    std::set<std::wstring> expected = {L"DebuggingModes",
+    std::set<std::wstring> expected = {L"ConfiguredTaskAwaiter",
+                                       L"DebuggingModes",
                                        L"Enumerator",
+                                       L"System.ArgumentNullException",
                                        L"System.Array",
                                        L"System.Attribute",
                                        L"System.AttributeTargets",
@@ -139,12 +141,12 @@ TEST_F(CLRHelperTest, GetsTypeInfoFromTypeRefs)
                                        L"System.Reflection.AssemblyTitleAttribute",
                                        L"System.Runtime.CompilerServices.AsyncStateMachineAttribute",
                                        L"System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1",
+                                       L"System.Runtime.CompilerServices.ConfiguredTaskAwaitable",
+                                       L"System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1",
                                        L"System.Runtime.CompilerServices.CompilationRelaxationsAttribute",
                                        L"System.Runtime.CompilerServices.CompilerGeneratedAttribute",
                                        L"System.Runtime.CompilerServices.IAsyncStateMachine",
                                        L"System.Runtime.CompilerServices.RuntimeCompatibilityAttribute",
-                                       L"System.Runtime.CompilerServices.TaskAwaiter",
-                                       L"System.Runtime.CompilerServices.TaskAwaiter`1",
                                        L"System.Runtime.Versioning.TargetFrameworkAttribute",
                                        L"System.RuntimeTypeHandle",
                                        L"System.String",
@@ -161,6 +163,23 @@ TEST_F(CLRHelperTest, GetsTypeInfoFromTypeRefs)
         if (type_info.IsValid())
         {
             actual.insert(type_info.name);
+            std::cout << "Found TypeRef: " << ToString(type_info.name) << std::endl;
+        }
+    }
+
+    for (const auto& name : expected)
+    {
+        if (actual.find(name) == actual.end())
+        {
+            std::cout << "Missing TypeRef: " << ToString(name) << std::endl;
+        }
+    }
+
+    for (const auto& name : actual)
+    {
+        if (expected.find(name) == expected.end())
+        {
+            std::cout << "Unexpected TypeRef: " << ToString(name) << std::endl;
         }
     }
     EXPECT_EQ(expected, actual);

test/test-applications/integrations/Directory.Build.props

@@ -12,4 +12,9 @@
   <ItemGroup>
     <Compile Include="$(MSBuildThisFileDirectory)GlobalSuppressions.cs" Link="GlobalSuppressions.integrations.cs" />
   </ItemGroup>
+  <PropertyGroup>
+    <!-- CA1031: Do not catch general exception types -->
+    <!-- CA1303: Do not pass literals as localized parameters -->
+    <NoWarn>$(NoWarn);CA1031;CA1303</NoWarn>
+  </PropertyGroup>
 </Project>

test/test-applications/integrations/TestApplication.Azure/Program.cs

@@ -21,9 +21,9 @@
 var containerClient = blobServiceClient.GetBlobContainerClient(containerName);
 
 // Create the container if it does not exist
-await containerClient.CreateIfNotExistsAsync();
+await containerClient.CreateIfNotExistsAsync().ConfigureAwait(false);
 
-var exists = await containerClient.ExistsAsync();
+var exists = await containerClient.ExistsAsync().ConfigureAwait(false);
 
 Console.WriteLine(exists);
 

test/test-applications/integrations/TestApplication.ContinuousProfiler.ContextTracking/Program.cs

@@ -16,7 +16,7 @@ public static async Task Main(string[] args)
         // and verify that trace context flows properly between threads that carry out parts of the async operation.
         using var activity = Source.StartActivity();
 
-        await DoSomethingAsync();
+        await DoSomethingAsync().ConfigureAwait(false);
     }
 
     private static async Task DoSomethingAsync()

test/test-applications/integrations/TestApplication.ContinuousProfiler/ClassA.cs

@@ -110,21 +110,22 @@ public static void MethodAOthers<T>(
         static void Action(int s) => InternalClassB<string, int>.DoubleInternalClassB.TripleInternalClassB<int>.MethodB(s, [3], TimeSpan.Zero, 0, ["a"], []);
     }
 
+    [DefaultDllImportSearchPaths(DllImportSearchPath.SafeDirectories)]
 #if NET
     [DllImport("TestApplication.ContinuousProfiler.NativeDep")]
 #else
     [DllImport("TestApplication.ContinuousProfiler.NativeDep.dll")]
 #endif
     private static extern int OTelAutoCallbackTest(Callback fp, int n);
 
-    internal static class InternalClassB<TA, TD>
+    internal static class InternalClassB<T1, T4>
     {
         internal static class DoubleInternalClassB
         {
-            internal static class TripleInternalClassB<TC>
+            internal static class TripleInternalClassB<T3>
             {
                 [MethodImpl(MethodImplOptions.NoInlining)]
-                public static void MethodB<TB>(int testArg, TC[] a, TB b, TD t, IList<TA> c, IList<string> d)
+                public static void MethodB<T2>(int testArg, T3[] a, T2 b, T4 t, IList<T1> c, IList<string> d)
                 {
                     OTelAutoCallbackTest(TestCallback, testArg);
                 }

test/test-applications/integrations/TestApplication.ContinuousProfiler/Exporter/AllocationSample.cs

@@ -3,7 +3,7 @@
 
 namespace TestApplication.ContinuousProfiler;
 
-internal class AllocationSample
+internal sealed class AllocationSample
 {
     public AllocationSample(long allocationSizeBytes, string allocationTypeName, ThreadSample threadSample)
     {

test/test-applications/integrations/TestApplication.ContinuousProfiler/Exporter/ExtendedPprofBuilder.cs

@@ -9,7 +9,7 @@
 
 namespace TestApplication.ContinuousProfiler;
 
-internal class ExtendedPprofBuilder
+internal sealed class ExtendedPprofBuilder
 {
     private readonly LocationCache _locationCache;
     private readonly LinkCache _linkCache;

test/test-applications/integrations/TestApplication.ContinuousProfiler/Exporter/OtlpOverHttpExporter.cs

@@ -14,7 +14,7 @@
 
 namespace TestApplication.ContinuousProfiler;
 
-public class OtlpOverHttpExporter
+internal class OtlpOverHttpExporter
 {
     private const string MediaContentType = "application/x-protobuf";
 
@@ -257,6 +257,11 @@ private static ScopeProfiles CreateScopeProfiles()
         return scopeProfiles;
     }
 
+    private static ExportRequestContent CreateHttpContent(ExportProfilesServiceRequest exportRequest)
+    {
+        return new ExportRequestContent(exportRequest);
+    }
+
     private HttpResponseMessage SendHttpRequest(HttpRequestMessage request, CancellationToken cancellationToken)
     {
 #if NET
@@ -266,11 +271,6 @@ private HttpResponseMessage SendHttpRequest(HttpRequestMessage request, Cancella
 #endif
     }
 
-    private HttpContent CreateHttpContent(ExportProfilesServiceRequest exportRequest)
-    {
-        return new ExportRequestContent(exportRequest);
-    }
-
     private HttpRequestMessage CreateHttpRequest(ExportProfilesServiceRequest exportRequest)
     {
         var request = new HttpRequestMessage(HttpMethod.Post, _endpoint);

test/test-applications/integrations/TestApplication.ContinuousProfiler/Exporter/ResourcesProvider.cs

@@ -5,7 +5,7 @@
 
 namespace TestApplication.ContinuousProfiler;
 
-internal class ResourcesProvider
+internal sealed class ResourcesProvider
 {
     public static Resource Resource { get; private set; } = Resource.Empty;
 

test/test-applications/integrations/TestApplication.ContinuousProfiler/Exporter/SampleBuilder.cs

@@ -5,7 +5,7 @@
 
 namespace TestApplication.ContinuousProfiler;
 
-internal class SampleBuilder
+internal sealed class SampleBuilder
 {
     private readonly Sample _sample = new();
     private long? _value;