Skip to content

Commit f80b986

Browse files
committed
TODOs
1 parent 9af8951 commit f80b986

File tree

8 files changed

+13
-0
lines changed

8 files changed

+13
-0
lines changed

test/IntegrationTests/AspNetTests.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ public async Task SubmitsTraces(AppPoolMode appPoolMode, Gac useGac)
8383
var webPort = TcpPortProvider.GetOpenPort();
8484
var imageName = GetTestImageName(appPoolMode, useGac);
8585
#pragma warning disable CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
86+
// TODO remove pragma when https://github.com/dotnet/roslyn-analyzers/issues/7185 is fixed
8687
await using var container = await IISContainerTestHelper.StartContainerAsync(imageName, webPort, environmentVariables, Output);
8788
#pragma warning restore CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
8889
await CallTestApplicationEndpoint(webPort).ConfigureAwait(true);
@@ -157,6 +158,7 @@ public async Task SubmitTracesCapturesHttpHeaders(AppPoolMode appPoolMode, Gac u
157158
var webPort = TcpPortProvider.GetOpenPort();
158159
var imageName = GetTestImageName(appPoolMode, useGac);
159160
#pragma warning disable CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
161+
// TODO remove pragma when https://github.com/dotnet/roslyn-analyzers/issues/7185 is fixed
160162
await using var container = await IISContainerTestHelper.StartContainerAsync(imageName, webPort, environmentVariables, Output);
161163
#pragma warning restore CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
162164
await CallTestApplicationEndpoint(webPort).ConfigureAwait(true);
@@ -191,6 +193,7 @@ public async Task TracesResource()
191193

192194
var webPort = TcpPortProvider.GetOpenPort();
193195
#pragma warning disable CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
196+
// TODO remove pragma when https://github.com/dotnet/roslyn-analyzers/issues/7185 is fixed
194197
await using var container = await IISContainerTestHelper.StartContainerAsync("testapplication-aspnet-netframework-integrated", webPort, environmentVariables, Output);
195198
#pragma warning restore CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
196199
await CallTestApplicationEndpoint(webPort).ConfigureAwait(true);
@@ -222,6 +225,7 @@ public async Task SubmitMetrics()
222225
};
223226
var webPort = TcpPortProvider.GetOpenPort();
224227
#pragma warning disable CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
228+
// TODO remove pragma when https://github.com/dotnet/roslyn-analyzers/issues/7185 is fixed
225229
await using var container = await IISContainerTestHelper.StartContainerAsync("testapplication-aspnet-netframework-integrated", webPort, environmentVariables, Output);
226230
#pragma warning restore CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
227231
await CallTestApplicationEndpoint(webPort).ConfigureAwait(true);

test/IntegrationTests/Helpers/MockMetricsCollector.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,7 @@ private void WriteOutput(string msg)
236236
}
237237

238238
#pragma warning disable CA1812 // Mark members as static. There is some issue in dotnet format.
239+
// TODO remove pragma when dotnet format issue is fixed
239240
internal sealed class Collected
240241
#pragma warning restore CA1812 // Mark members as static. There is some issue in dotnet format.
241242
{

test/IntegrationTests/Helpers/MockSpansCollector.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
namespace IntegrationTests.Helpers;
1818

1919
#pragma warning disable CA1812 // Mark members as static. There is some issue in dotnet format.
20+
// TODO remove pragma when dotnet format issue is fixed
2021
internal sealed class MockSpansCollector : IDisposable
2122
#pragma warning restore CA1812 // Mark members as static. There is some issue in dotnet format.
2223
{
@@ -225,6 +226,7 @@ private void WriteOutput(string msg)
225226
}
226227

227228
#pragma warning disable CA1812 // Mark members as static. There is some issue in dotnet format.
229+
// TODO remove pragma when dotnet format issue is fixed
228230
internal sealed class Collected
229231
#pragma warning restore CA1812 // Mark members as static. There is some issue in dotnet format.
230232
{

test/IntegrationTests/Helpers/PathHandler.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
namespace IntegrationTests.Helpers;
88

99
#pragma warning disable CA1812 // Mark members as static. There is some issue in dotnet format.
10+
// TODO remove pragma when dotnet format issue is fixed
1011
internal sealed class PathHandler
1112
#pragma warning restore CA1812 // Mark members as static. There is some issue in dotnet format.
1213
{

test/IntegrationTests/OwinIISTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public async Task SubmitsTraces()
4747
};
4848
var webPort = TcpPortProvider.GetOpenPort();
4949
#pragma warning disable CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
50+
// TODO remove pragma when https://github.com/dotnet/roslyn-analyzers/issues/7185 is fixed
5051
await using var container = await IISContainerTestHelper.StartContainerAsync("testapplication-owin-iis-netframework", webPort, environmentVariables, Output);
5152
#pragma warning restore CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
5253

@@ -80,6 +81,7 @@ public async Task SubmitMetrics()
8081
};
8182
var webPort = TcpPortProvider.GetOpenPort();
8283
#pragma warning disable CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
84+
// TODO remove pragma when https://github.com/dotnet/roslyn-analyzers/issues/7185 is fixed
8385
await using var container = await IISContainerTestHelper.StartContainerAsync("testapplication-owin-iis-netframework", webPort, environmentVariables, Output);
8486
#pragma warning restore CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
8587

test/IntegrationTests/VerboseTestFramework.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
namespace IntegrationTests.Helpers;
1111

1212
#pragma warning disable CA1812 // Mark members as static. There is some issue in dotnet format.
13+
// TODO remove pragma when dotnet format issue is fixed
1314
public class VerboseTestFramework : XunitTestFramework
1415
{
1516
public VerboseTestFramework(IMessageSink messageSink)

test/IntegrationTests/WcfIISTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ public async Task SubmitsTraces()
5555
_environmentVariables["OTEL_EXPORTER_OTLP_ENDPOINT"] = collectorUrl;
5656

5757
#pragma warning disable CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
58+
// TODO remove pragma when https://github.com/dotnet/roslyn-analyzers/issues/7185 is fixed
5859
await using var container = await StartContainerAsync(netTcpPort, httpPort);
5960
#pragma warning restore CA2007 // Do not directly await a Task. https://github.com/dotnet/roslyn-analyzers/issues/7185
6061

test/OpenTelemetry.AutoInstrumentation.Bootstrapping.Tests/FactRequiringEnvVarAttribute.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
namespace OpenTelemetry.AutoInstrumentation.Bootstrapping.Tests;
77

88
#pragma warning disable CA1812 // Mark members as static. There is some issue in dotnet format.
9+
// TODO remove pragma when dotnet format issue is fixed
910
internal sealed class FactRequiringEnvVarAttribute : FactAttribute
1011
#pragma warning restore CA1812 // Mark members as static. There is some issue in dotnet format.
1112
{

0 commit comments

Comments
 (0)