Skip to content

Commit 74ad003

Browse files
[HttpClient & ASP.NET Core] Change metric descriptions as per spec (#4990)
1 parent f7b4ae1 commit 74ad003

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,10 @@ to `http` or `http/dup`.
109109
> The [View API](https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/metrics/customizing-the-sdk#select-specific-tags)
110110
may be used to drop dimensions.
111111

112+
* Updated description for `http.server.request.duration` metrics to match spec
113+
definition.
114+
([#4990](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4990))
115+
112116
## 1.5.1-beta.1
113117

114118
Released 2023-Jul-20

src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInMetricsListener.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ internal HttpInMetricsListener(string name, Meter meter, AspNetCoreMetricsInstru
5959

6060
if (this.emitNewAttributes)
6161
{
62-
this.httpServerRequestDuration = meter.CreateHistogram<double>(HttpServerRequestDurationMetricName, "s", "Measures the duration of inbound HTTP requests.");
62+
this.httpServerRequestDuration = meter.CreateHistogram<double>(HttpServerRequestDurationMetricName, "s", "Duration of HTTP server requests.");
6363
}
6464
}
6565

src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,15 @@
6363

6464
([#4931](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4931))
6565

66-
* Added `url.scheme` attribute to `http.client.request.duration` metric. The
66+
* Added `url.scheme` attribute to `http.client.request.duration` metric. The
6767
metric will be emitted when `OTEL_SEMCONV_STABILITY_OPT_IN` environment
6868
variable is set to `http` or `http/dup`.
6969
([#4989](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4989))
7070

71+
* Updated description for `http.client.request.duration` metrics to match spec
72+
definition.
73+
([#4990](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4990))
74+
7175
## 1.5.1-beta.1
7276

7377
Released 2023-Jul-20

src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerMetricsDiagnosticListener.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ internal sealed class HttpHandlerMetricsDiagnosticListener : ListenerHandler
3737
internal static readonly string MeterVersion = AssemblyName.Version.ToString();
3838
internal static readonly Meter Meter = new(MeterName, MeterVersion);
3939
private static readonly Histogram<double> HttpClientDuration = Meter.CreateHistogram<double>("http.client.duration", "ms", "Measures the duration of outbound HTTP requests.");
40-
private static readonly Histogram<double> HttpClientRequestDuration = Meter.CreateHistogram<double>("http.client.request.duration", "s", "Measures the duration of outbound HTTP requests.");
40+
private static readonly Histogram<double> HttpClientRequestDuration = Meter.CreateHistogram<double>("http.client.request.duration", "s", "Duration of HTTP client requests.");
4141

4242
private static readonly PropertyFetcher<HttpRequestMessage> StopRequestFetcher = new("Request");
4343
private static readonly PropertyFetcher<HttpResponseMessage> StopResponseFetcher = new("Response");

0 commit comments

Comments
 (0)