Why is EventId with ID set to 0 not being added to OTLP Log Record?

[davidkaya]

Hello,

I have noticed, that if the log record has an EventId with ID set to 0, the EventId will no be added to the OTLP Log Record:

opentelemetry-dotnet/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/LogRecordExtensions.cs

Lines 96 to 99 in 5784b45

	if (logRecord.EventId.Id != default)
	{
	otlpLogRecord.AddIntAttribute(nameof(logRecord.EventId.Id), logRecord.EventId.Id, attributeCountLimit);
	}

Is there some specific reason behind that? Is this possibly a bug?

Thank you

[cijothomas]

0 is the default, i.e its treated as if eventid is not set at all.

Separately, EventId will be temporarily removed from OTLP Exporter to stabilize it. See #4776

[davidkaya]

That's unfortunate though. Even ASP NET Core itself has few logs with EventId set to 0. It might be nice to revisit the "default" event id when it will be stabilized.

[cijothomas]

Can you point to the places where Asp.Net Core uses EventId 0? We can ask the owners to see if that was intentional..

[davidkaya]

I have reported an issue here dotnet/runtime#90831
It contains links to ASP.NET Core repo