Skip to content

Commit be15d75

Browse files
authored
fix: show accurate error message when versions list fails to load in ConfigurationBuilderPage (#514)
Co-authored-by: Rama542 <Rama542@users.noreply.github.com>
1 parent 50fcba6 commit be15d75

1 file changed

Lines changed: 42 additions & 36 deletions

File tree

ecosystem-explorer/src/features/java-agent/configuration/configuration-builder-page.tsx

Lines changed: 42 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -352,42 +352,48 @@ export function ConfigurationBuilderPage() {
352352
) : null}
353353
</div>
354354
</div>
355-
<Tabs value={activeTab} onValueChange={setActiveTab}>
356-
<TabsContent value="sdk">
357-
{!schemaVersion || schema.loading || starter.loading ? (
358-
<p className="text-muted-foreground mt-4 text-sm">Loading schema…</p>
359-
) : schema.error ? (
360-
<p className="mt-4 text-sm text-red-400">Failed to load schema.</p>
361-
) : starter.error ? (
362-
<p className="mt-4 text-sm text-red-400">Failed to load starter template.</p>
363-
) : root ? (
364-
<SdkTabContent
365-
schema={root}
366-
starter={starter.data}
367-
schemaVersion={schemaVersion}
368-
javaAgentVersion={javaAgentVersion}
369-
activeTab={activeTab}
370-
/>
371-
) : null}
372-
</TabsContent>
373-
<TabsContent value="instrumentation">
374-
{!schemaVersion || schema.loading || starter.loading ? (
375-
<p className="text-muted-foreground mt-4 text-sm">Loading schema…</p>
376-
) : schema.error ? (
377-
<p className="mt-4 text-sm text-red-400">Failed to load schema.</p>
378-
) : starter.error ? (
379-
<p className="mt-4 text-sm text-red-400">Failed to load starter template.</p>
380-
) : root ? (
381-
<InstrumentationTabContent
382-
schema={root}
383-
starter={starter.data}
384-
schemaVersion={schemaVersion}
385-
javaAgentVersion={javaAgentVersion}
386-
activeTab={activeTab}
387-
/>
388-
) : null}
389-
</TabsContent>
390-
</Tabs>
355+
{schemaVersionsState.loading ? (
356+
<p className="text-muted-foreground mt-4 text-sm">Loading versions…</p>
357+
) : schemaVersionsState.error ? (
358+
<p className="mt-4 text-sm text-red-400">Failed to load available versions.</p>
359+
) : (
360+
<Tabs value={activeTab} onValueChange={setActiveTab}>
361+
<TabsContent value="sdk">
362+
{!schemaVersion || schema.loading || starter.loading ? (
363+
<p className="text-muted-foreground mt-4 text-sm">Loading schema…</p>
364+
) : schema.error ? (
365+
<p className="mt-4 text-sm text-red-400">Failed to load schema.</p>
366+
) : starter.error ? (
367+
<p className="mt-4 text-sm text-red-400">Failed to load starter template.</p>
368+
) : root ? (
369+
<SdkTabContent
370+
schema={root}
371+
starter={starter.data}
372+
schemaVersion={schemaVersion}
373+
javaAgentVersion={javaAgentVersion}
374+
activeTab={activeTab}
375+
/>
376+
) : null}
377+
</TabsContent>
378+
<TabsContent value="instrumentation">
379+
{!schemaVersion || schema.loading || starter.loading ? (
380+
<p className="text-muted-foreground mt-4 text-sm">Loading schema…</p>
381+
) : schema.error ? (
382+
<p className="mt-4 text-sm text-red-400">Failed to load schema.</p>
383+
) : starter.error ? (
384+
<p className="mt-4 text-sm text-red-400">Failed to load starter template.</p>
385+
) : root ? (
386+
<InstrumentationTabContent
387+
schema={root}
388+
starter={starter.data}
389+
schemaVersion={schemaVersion}
390+
javaAgentVersion={javaAgentVersion}
391+
activeTab={activeTab}
392+
/>
393+
) : null}
394+
</TabsContent>
395+
</Tabs>
396+
)}
391397
</div>
392398
</PageContainer>
393399
);

0 commit comments

Comments
 (0)