Skip to content

Commit a946e03

Browse files
committed
[FIX] fix change log entry
1 parent 71677bc commit a946e03

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
2121
### Changed
2222

2323
- Jaeger remote sampler's probabilistic strategy now uses the same sampling algorithm as `trace.TraceIDRatioBased` in `go.opentelemetry.io/contrib/samplers/jaegerremote`. (#6892)
24-
- - Migrated `otelecho` instrumentation to use OpenTelemetry semantic conventions (`semconv`) for HTTP attributes. (#6980)
24+
- Support for the `OTEL_SEMCONV_STABILITY_OPT_IN=http/dup` environment variable in `go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho` to emit attributes for both the v1.20.0 and v1.26.0 semantic conventions. (#6980)
2525

2626
### Fixed
2727

instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// Copyright The OpenTelemetry Authors
55
// SPDX-License-Identifier: Apache-2.0
66

7-
package semconvutil // import "go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil"
7+
package semconvutil
88

99
import (
1010
"fmt"

instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/netconv.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// Copyright The OpenTelemetry Authors
55
// SPDX-License-Identifier: Apache-2.0
66

7-
package semconvutil // import "go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil"
7+
package semconvutil // import "go.opentelemetry.io/contrib/internal/shared/semconvutil"
88

99
import (
1010
"net"

instrumentation/github.com/labstack/echo/otelecho/internal/semconv/test/common_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,5 +67,5 @@ func testTraceRequest(t *testing.T, serv semconv.HTTPServer, want func(testServe
6767
clientIP: clientIP,
6868
}
6969

70-
assert.ElementsMatch(t, want(srvReq), serv.RequestTraceAttrs("", req))
70+
assert.ElementsMatch(t, want(srvReq), serv.RequestTraceAttrs("", req, semconv.RequestTraceAttrsOpts{}))
7171
}

instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// Copyright The OpenTelemetry Authors
55
// SPDX-License-Identifier: Apache-2.0
66

7-
package semconvutil // import "go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil"
7+
package semconvutil
88

99
import (
1010
"fmt"

instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/netconv.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// Copyright The OpenTelemetry Authors
55
// SPDX-License-Identifier: Apache-2.0
66

7-
package semconvutil // import "go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil"
7+
package semconvutil // import "go.opentelemetry.io/contrib/internal/shared/semconvutil"
88

99
import (
1010
"net"

0 commit comments

Comments
 (0)