refactor: use Key's Defined method (#2593)

1046102779 · web-flow · commit b01dc21f6c11 · 2022-02-10T19:41:34.000-05:00
* optimize(attribute): use Key's Defined method

* Update kv.go
diff --git a/attribute/kv.go b/attribute/kv.go
@@ -26,7 +26,7 @@ type KeyValue struct {
 
 // Valid returns if kv is a valid OpenTelemetry attribute.
 func (kv KeyValue) Valid() bool {
-	return kv.Key != "" && kv.Value.Type() != INVALID
+	return kv.Key.Defined() && kv.Value.Type() != INVALID
 }
 
 // Bool creates a KeyValue with a BOOL Value type.

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ type KeyValue struct {`
`26`	`26`
`27`	`27`	`// Valid returns if kv is a valid OpenTelemetry attribute.`
`28`	`28`	`func (kv KeyValue) Valid() bool {`
`29`		`- return kv.Key != "" && kv.Value.Type() != INVALID`
	`29`	`+ return kv.Key.Defined() && kv.Value.Type() != INVALID`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`// Bool creates a KeyValue with a BOOL Value type.`