How to identify current span (i.e. read its attributes)

[dalbani]

I raised an issue at open-telemetry/semantic-conventions#3237 about the (currently .NET specific) convention for traces related to HTTP connection setup.

In the meantime, curious to see if it could be implemented using the Java agent, I made an attempt to instrument the classes in the JDK responsible for DNS, socket and TLS related operations.

In practice, I instrumented:

• java.net.InetAddress::getAllByName
• java.net.Socket::connect
• javax.net.ssl.SSLSocket::startHandshake

I've managed to get something working as a proof of concept, but I ran into the issue that these classes are called in more situations than only HTTP requests.
So I thought of checking what the current span is before producing a new span: i.e. do it only when the current one is kind=CLIENT and http.request.method=XXX.

But the issue is that I couldn't find a reliable way to determine if the current span is one for an client HTTP request.
As the only ReadableSpan implementation is io.opentelemetry.sdk.trace.SdkTrace, which is not a public class.

So what are the options? Apart from hacking the output of the toString() method 😅

[laurit]

You could use reflection. I'd guess that you can't cast the current span to ReadableSpan in instrumentation code, you probably could cast it in the agent code. You'd need to have some sort of api in boot loader that lets you call from within the instrumentation into the agent.
You should also consider whether it would be better to instrument the parts of the http client that call these methods instead. For example something like this is implemented for netty, search for the flags mentioned in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/netty/README.md