Consider changing "instrumentation name" from `-` to `_`

[trask]

Consider changing "instrumentation name" from - to _, due to representation in declarative configuration:

instrumentation/development:
  java:
    apache_httpclient:
      enabled: false

Also consider changing scope name.

From @zeitlinger's #15698 (comment)

[jaydeluca]

should this be part of the 3.0 milestone since this will be a pretty significant breaking change in terms of user experience (i'm thinking about suppressing instrumentation)? or should we add support for the _ for a while while maintaining backwards compatibility for a time?

[trask]

I don't think we want to change otel.instrumentation.abc-xyz.enabled since all properties use - instead of _.

We could change it internally though so the _ is the name, but then we expose that with dashes in the (non-declarative) property.

There may be other impacts though, e.g. to scope name(?) which we'd need to identify and evaluate if they need to wait for 3.0

[zeitlinger]

I don't think we want to change otel.instrumentation.abc-xyz.enabled since all properties use - instead of _.

correct

We could change it internally though so the _ is the name, but then we expose that with dashes in the (non-declarative) property.

that is what #15845 does

There may be other impacts though, e.g. to scope name(?) which we'd need to identify and evaluate if they need to wait for 3.0

I would first like to discuss if we do this at all - because it may impact users dashboards