-
Notifications
You must be signed in to change notification settings - Fork 1k
Open
Labels
enhancementNew feature or requestNew feature or requestneeds triageNew issue that requires triageNew issue that requires triage
Description
With #15787 there are only a few places left that access "otel.javaagent.*" directly and that access ConfigPropertiesUtil
- copy
ConfigPropertiesUtilto aDeprecatedConfigPropertiesUtiland change all usages unless noted otherwise below- DeprecatedConfigPropertiesUtil will be removed in 3.0 (remove system property access from library instrumentation #15810)
otel.javaagent.testing.*- should keep access via system properties, because we also want to test with declarative config without having to add to the yaml file
- most access via
System.getPropertydirectly - some use
ConfigPropertiesUtil- change for consistency
otel.javaagent.debug- in
ContextPropagationDebug(instrumentation-api) - can't accessEarlyInitAgentConfig - in
SupportabilityMetrics(instrumentation-api) - can't accessEarlyInitAgentConfig
- in
otel.javaagent.experimental.thread-propagation-debugger.enabled- should be renamed to be have
otel.javaagent.testing.prefix
- should be renamed to be have
otel.instrumentation.internal-reflection.enabled- use
otel.javaagent.internal-reflection.enabled(access via EarlyInitAgentConfig) as this is a property that must be available early in startup
- use
otel.javaagent.experimental.initializer.jar- keep using
ConfigPropertiesUtil
- keep using
otel.semconv-stability.opt-in- keep using
ConfigPropertiesUtil - need to decide is this should be configurable in yaml file: support OTEL_SEMCONV_STABILITY_OPT_IN ? opentelemetry-configuration#492
- keep using
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestneeds triageNew issue that requires triageNew issue that requires triage
Type
Projects
Status
Awaiting Review