Should requireParentForOutgoingSpans also suppress further child spans?
#3235
evantorrie
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
In @opentelemetry/instrumentation-http, the
requireParentSpanForOutgoingSpansoperates as the documentation specifies, which is to prevent an http span from being created if there is no parent span currently active.However, it doesn't say anything about further child spans of the HTTP request.
For example
tcp.connectandtls.connectspans will both be generated by thenetinstrumentation.These spans appear without the http parent span, but in doing so, can be confusing to the user who may not understand why a dns lookup and a tcp.connect is happening when they turned
requireParentForOutgoingSpans: trueon for HTTP instrumentation.Would it make more sense that
requireParentForOutgoingSpans: truehave its semantics changed, or another option provided, that not only omits the HTTP span, but also sets asuppressInstrumentationon the current context such that no further spans will be created by other instrumentation until the HTTP call completes?Beta Was this translation helpful? Give feedback.
All reactions