All customs spans broken in Puter after upgrading opentelemetry #6204
Unanswered
KernelDeimos
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello, I maintain the backend for Puter. For years I've had opentelemetry and jaeger working together to diagnose performance issues but after upgrading it appears we've lost this. I've spent the past 2 days trying to get it back to no avail. This week we're planning on going full-focus on performance and this is really messing up our plans.
It all started after we upgraded opentelemetry packages. I wasn't able to run Puter with the performance module enabled anymore until these two commits fixed it:
This fix itself seems pretty harmless - we pass
spanProcessorsin the constructor of the provider now instead of callingaddSpanProcessor. While I feel introducing this regression was unnecessary it wasn't a big deal once we found out what we needed to do. (however if the method was replaced with a method that throws an exception explaining the regression we would have found this much quicker)If I try to run everything the same as before I don't see any custom spans. In jaeger, I only ever see the built-in spans for things like HTTP requests and accessing files on the system. I've tried a lot of different things to fix it - re-ordering things, using getTracer from
getTraceProvider()instead, callinggetTracerwhere specific things are instrumented as the documentation recommends, etc; nothing is working. I'm writing this now because I don't know what to try next - I have run out of ideas.For now we have downgraded and everything is working again.
Beta Was this translation helpful? Give feedback.
All reactions