-
Notifications
You must be signed in to change notification settings - Fork 953
Open
Labels
DiscussionIssue or PR that needs/is extended discussion.Issue or PR that needs/is extended discussion.pkg:instrumentationtype:researchSomething needs to be researched, results should be documented on the issue.Something needs to be researched, results should be documented on the issue.
Description
The instrumentation package was recently updated to depend on import-in-the-middle 2. This should not cause issues for most people.
However there is a possibility that two different versions of the library could be loaded in the same process if an instrumentation implementation depends on an older version of the instrumentation package, which in turns depends on a 1.x.x release of import-in-the-middle. This could potentially be a problem if also using some of the stateful APIs provided by the library.
- We should check whether having two separate versions actually causes any problems, or if
import-in-the-middlehandles that fine. - In the case where it does cause issues, we should consider relaxing the bound to
>=1.8.1 <3so that the dependency gets resolved to a single version if some components requires a1.x.xversion. - In either case, we should probably add some kind of test to check the behaviour when multiple versions of
import-in-the-middleare used, even if just to better be able to diagnose it if someone ever opens an issue.
Metadata
Metadata
Assignees
Labels
DiscussionIssue or PR that needs/is extended discussion.Issue or PR that needs/is extended discussion.pkg:instrumentationtype:researchSomething needs to be researched, results should be documented on the issue.Something needs to be researched, results should be documented on the issue.