Skip to content

Commit 24e884e

Browse files
committed
Review comments
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
1 parent 49f5cdc commit 24e884e

1 file changed

Lines changed: 13 additions & 5 deletions

File tree

docs/rfcs/instrumentation-v1beta1.md

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -284,12 +284,20 @@ This allows gradual migration: users can switch to labels at their own pace whil
284284

285285
#### Deprecation path
286286

287-
1. **v1beta1**: Both labels and annotations supported. Annotations deprecated but functional.
288-
2. **v1alpha1 removal**: Labels become the primary mechanism. Annotations support is dropped.
287+
**Phase 1 — v1beta1 (transition period):**
288+
- Both labels and annotations supported
289+
- No `objectSelector` on webhook — all pods still pass through (required for annotation backwards compatibility)
290+
- Annotations deprecated in documentation
291+
- Operator logs deprecation warnings when annotations are used
289292

290-
#### Webhook optimization
293+
**Phase 2 — v1alpha1 removal:**
294+
- Annotations support dropped
295+
- `objectSelector` enabled on webhook — only pods with labels are processed
296+
- Significant performance improvement for large clusters
291297

292-
With labels, the operator can configure the MutatingWebhookConfiguration with an `objectSelector`:
298+
##### Webhook optimization (Phase 2)
299+
300+
Once annotation support is removed, the operator can configure the MutatingWebhookConfiguration with an `objectSelector`:
293301

294302
```yaml
295303
webhooks:
@@ -303,7 +311,7 @@ webhooks:
303311
# ... other languages
304312
```
305313

306-
This reduces webhook invocations to only pods that have opted in via labels, improving cluster performance. Pods using legacy annotations will still pass through the webhook (no `objectSelector` match), maintaining backwards compatibility.
314+
This reduces webhook invocations to only pods that have opted in via labels, improving cluster performance. This optimization is only possible after annotations are no longer supported, since `objectSelector` cannot match annotations.
307315

308316
## CRD Spec
309317

0 commit comments

Comments
 (0)