Skip to content

Commit 305c1c7

Browse files
authored
Add SDK TracerProviderInterface to expose ::shutdown() and ::forceFlush() (#756)
1 parent 8e30ea0 commit 305c1c7

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

src/SDK/Trace/TracerProvider.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
use function spl_object_id;
1919
use WeakReference;
2020

21-
final class TracerProvider implements API\TracerProviderInterface
21+
final class TracerProvider implements TracerProviderInterface
2222
{
2323
/** @var array<int, WeakReference<self>>|null */
2424
private static ?array $tracerProviders = null;
@@ -58,7 +58,7 @@ public function __construct(
5858
self::registerShutdownFunction($this);
5959
}
6060

61-
public function forceFlush(): ?bool
61+
public function forceFlush(): bool
6262
{
6363
return $this->tracerSharedState->getSpanProcessor()->forceFlush();
6464
}

src/SDK/Trace/TracerProviderFactory.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
namespace OpenTelemetry\SDK\Trace;
66

7-
use OpenTelemetry\API\Trace as API;
87
use OpenTelemetry\SDK\Behavior\LogsMessagesTrait;
98

109
final class TracerProviderFactory
@@ -26,7 +25,7 @@ public function __construct(
2625
$this->spanProcessorFactory = $spanProcessorFactory ?: new SpanProcessorFactory();
2726
}
2827

29-
public function create(): API\TracerProviderInterface
28+
public function create(): TracerProviderInterface
3029
{
3130
try {
3231
$exporter = $this->exporterFactory->fromEnvironment();
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace OpenTelemetry\SDK\Trace;
6+
7+
use OpenTelemetry\API\Trace as API;
8+
9+
interface TracerProviderInterface extends API\TracerProviderInterface
10+
{
11+
public function forceFlush(): bool;
12+
13+
public function shutdown(): bool;
14+
}

0 commit comments

Comments
 (0)