Remove STDOUT output in Newrelic exporter (#404)

lalex · web-flow · commit 45b7750ec3de · 2021-08-27T16:37:41.000-04:00
diff --git a/contrib/Newrelic/Exporter.php b/contrib/Newrelic/Exporter.php
@@ -146,14 +146,6 @@ public function export(iterable $spans): int
             return Trace\Exporter::FAILED_RETRYABLE;
         }
 
-        $statusCode = $response->getStatusCode();
-        $reason = $response->getReasonPhrase();
-
-        // Useful information for when logging is implemented.
-        /*
-         * echo "\nsendRequest response = " . $statusCode . "\n";
-         * echo "\nsendRequest response = " . $reason . "\n";
-         */
         if ($response->getStatusCode() >= 400 && $response->getStatusCode() < 500) {
             return Trace\Exporter::FAILED_NOT_RETRYABLE;
         }
diff --git a/contrib/ZipkinToNewrelic/Exporter.php b/contrib/ZipkinToNewrelic/Exporter.php
@@ -135,11 +135,6 @@ public function export(iterable $spans): int
             return Trace\Exporter::FAILED_RETRYABLE;
         }
 
-        $statusCode = $response->getStatusCode();
-        $reason = $response->getReasonPhrase();
-        echo "\nsendRequest response = " . $statusCode . "\n";
-        echo "\nsendRequest response = " . $reason . "\n";
-
         if ($response->getStatusCode() >= 400 && $response->getStatusCode() < 500) {
             return Trace\Exporter::FAILED_NOT_RETRYABLE;
         }

Original file line number	Diff line number	Diff line change
`@@ -146,14 +146,6 @@ public function export(iterable $spans): int`
`146`	`146`	`return Trace\Exporter::FAILED_RETRYABLE;`
`147`	`147`	`}`
`148`	`148`
`149`		`- $statusCode = $response->getStatusCode();`
`150`		`- $reason = $response->getReasonPhrase();`
`151`		`-`
`152`		`- // Useful information for when logging is implemented.`
`153`		`- /*`
`154`		`- * echo "\nsendRequest response = " . $statusCode . "\n";`
`155`		`- * echo "\nsendRequest response = " . $reason . "\n";`
`156`		`- */`
`157`	`149`	`if ($response->getStatusCode() >= 400 && $response->getStatusCode() < 500) {`
`158`	`150`	`return Trace\Exporter::FAILED_NOT_RETRYABLE;`
`159`	`151`	`}`
Original file line number	Diff line number	Diff line change
`@@ -135,11 +135,6 @@ public function export(iterable $spans): int`
`135`	`135`	`return Trace\Exporter::FAILED_RETRYABLE;`
`136`	`136`	`}`
`137`	`137`
`138`		`- $statusCode = $response->getStatusCode();`
`139`		`- $reason = $response->getReasonPhrase();`
`140`		`- echo "\nsendRequest response = " . $statusCode . "\n";`
`141`		`- echo "\nsendRequest response = " . $reason . "\n";`
`142`		`-`
`143`	`138`	`if ($response->getStatusCode() >= 400 && $response->getStatusCode() < 500) {`
`144`	`139`	`return Trace\Exporter::FAILED_NOT_RETRYABLE;`
`145`	`140`	`}`