Skip to content

Development workflow should not run "sudo" #3187

Open
@michaelsafyan

Description

Running tox causes it to call sudo:

generate-workflows: OK ✔ in 4.59 seconds
shellcheck: recreate env because python changed virtualenv version='20.26.2'->'20.28.1'
shellcheck: remove tox env folder /usr/local/google/home/michaelsafyan/Code/github/michaelsafyan/open-telemetry.opentelemetry-python-contrib/.tox/shellcheck
shellcheck: commands_pre[0]> sh -c 'sudo apt update -y && sudo apt install --assume-yes shellcheck'
[sudo] password for michaelsafyan: 

It looks like it is attempting to install shellcheck. I already have this installed on my system:

$ shellcheck --version
ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net

But it would be even better, if there are external dependencies like this, to use a container with podman (or to use something like nix-shell) to ensure that the version of the tool is repeatable. At the very least, though, this step should be skipped if the tool is already installed.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions