-
Notifications
You must be signed in to change notification settings - Fork 889
Description
At release time we run scripts/eachdist.py to bump the package versions. Packages released independently should be excluded from this bump since they are doing their own versioning.
For 1.40.0 two genai instrumentation were missing from the exclude_release group in eachdist.ini and so their version was wrongly bumped in the prerelease workflow.
I'm not sure what consequences not catching this would have had, maybe a failure in the release step or maybe an upload of package with the wrong version.
To avoid this in the future we may add a test in CI that checks the the eventual bump make sense, a simple check can be that the new version is bigger than the current one and that is current+1. We need also a label to skip the check if that's what we really want to do.