Skip to content

Conventional commit prefixed with fix! did not result in a breaking change #1053

Open
@kaylareopelle

Description

@kaylareopelle

The conventional commits guidelines state that anything that appends a ! after a type/scope should result in a breaking change. (source)

#1038 brought to our attention that a recent change that included fix!(instrumentation): as the commit type when merged into main but this was not applied. Instead, the changes were treated like fix:.

We expected to see BREAKING CHANGE listed in the Changelog. Since the gem is still at 0.x, a major version bump shouldn't occur.

Metadata

Metadata

Assignees

No one assigned

    Labels

    keepEnsures stale-bot keeps this issue/PR open

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions