Skip to content

Determine the structure for Metrics instrumentation #1127

@kaylareopelle

Description

Metrics are still veryyy experimental, but, for those willing to take the risk, I'd like to start building instrumentation that can emit metrics.

Before we can do that, we need to decide how to keep the stable traces code safe from experimental metrics.

Current ideas:

  • More than one condition needs to be true to turn on metrics (show that you really really want this)
    • First requirement: The presence of the Metrics API is detected
    • Second requirement: The configuration enables metrics
  • Only emit HTTP metrics that

Potential approaches:

  • Similar to the ConfigurationPatch that allows the Metrics SDK to use the Configurator, create a separate module that only gets loaded if the conditions to enable metrics are met
  • Put conditionals everywhere to check to see if metrics should be generated
  • Create separate libraries to emit metrics (not a huge fan on this one)

Metadata

Assignees

Labels

keepEnsures stale-bot keeps this issue/PR open

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions