Skip to content

Commit 23f7d80

Browse files
vvydierbryce-b
andauthored
updates to README, tests and OTLP example (#956)
* fixes to README.md and Examples * fixes to README.md and Examples * fixes to README.md and Examples * update to the directory name in the test * Delete Package.resolved --------- Co-authored-by: Bryce Buchanan <75274611+bryce-b@users.noreply.github.com>
1 parent 2a0592a commit 23f7d80

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

Examples/OTLP Exporter/docker-compose.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ version: "3"
22
services:
33
# Collector
44
collector:
5+
platform: linux/amd64
56
image: otel/opentelemetry-collector:0.144.0@sha256:a43e68866ce4cfa701fb6711de3111b72660e40ebb05a79d1759b002938b608f
67
# The latest image of the otel-collector may not work, so specifying the version that works with this release
78
# image: otel/opentelemetry-collector:latest
@@ -17,12 +18,14 @@ services:
1718

1819
# Zipkin
1920
zipkin-all-in-one:
20-
image: openzipkin/zipkin:latest@sha256:bb570eb45c2994eaf32da783cc098b3d51d1095b73ec92919863d73d0a9eaafb
21+
platform: linux/amd64
22+
image: openzipkin/zipkin:latest
2123
ports:
2224
- "9411:9411"
2325

2426
# Prometheus
2527
prometheus:
28+
platform: linux/amd64
2629
container_name: prometheus
2730
image: prom/prometheus:latest@sha256:1f0f50f06acaceb0f5670d2c8a658a599affe7b0d8e78b898c1035653849a702
2831
volumes:

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,17 +83,17 @@ Metrics is implemented using an outdated spec, is fully functional but will chan
8383

8484
#### Traces
8585

86-
* Exporters: Stdout, Jaeger, Zipkin, Datadog and OpenTelemetry (OTLP) collector
86+
* Exporters: Stdout, Jaeger, Zipkin and OpenTelemetry (OTLP) grpc/http
8787
* Importers: OpenTracingShim
8888

8989
#### Metrics
9090

91-
* Exporters: Prometheus, Datadog, and OpenTelemetry (OTLP) collector
91+
* Exporters: Prometheus and OpenTelemetry (OTLP) grpc/http
9292
* Importers: SwiftMetricsShim
9393

9494
#### Logs
9595

96-
* Exporters: OpenTelemetry (OTLP) collector
96+
* Exporters: OpenTelemetry (OTLP) grpc/http
9797

9898
> **_NOTE:_** OTLP exporters are supported both in GRPC and HTTP, only GRPC is production ready, HTTP is still experimental
9999
@@ -113,7 +113,6 @@ In addition to the specified OpenTelemetry exporters, some third-party exporters
113113

114114
The package includes some example projects with basic functionality:
115115

116-
* `Datadog Sample` - Shows the Datadog exporter used with a Simple Exporter, showing how to configure for sending.
117116
* `Logging Tracer` - Simple api implementation of a Tracer that logs every api call
118117
* `Network Tracer` - Shows how to use the `URLSessionInstrumentation` instrumentation in your application
119118
* `Simple Exporter` - Shows the Jaeger an Stdout exporters in action using a MultiSpanExporter. Can be easily modified for other exporters

Tests/ExportersTests/OpenTelemetryProtocol/OtlpHttpTraceExporterTests.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ class OtlpHttpTraceExporterTests: XCTestCase {
6363
}
6464

6565
// This is not a thorough test of HTTPClient, but just enough to keep code coverage happy.
66-
// There is a more complete test as part of the DataDog exporter test
6766
func testHttpClient() {
6867
// Clear any previous requests
6968
testServer.clearReceivedRequests()

Tests/ExportersTests/PersistenceExporter/Helpers/TestsDirectory.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import XCTest
2424
}
2525

2626
init() {
27-
let subdirectoryName = "com.datadoghq.ios-sdk-tests-\(UUID().uuidString)"
27+
let subdirectoryName = "io.opentelemetry.ios-sdk-tests-\(UUID().uuidString)"
2828
let osTemporaryDirectoryURL = URL(fileURLWithPath: NSTemporaryDirectory(), isDirectory: true).appendingPathComponent(subdirectoryName, isDirectory: true)
2929
directory = Directory(url: osTemporaryDirectoryURL)
3030
}

0 commit comments

Comments
 (0)