Skip to content

Quite some issues in the Java manual instrumentation doc #3765

Open
@brightzheng100

Description

@brightzheng100

What needs to be changed? Describe the update that is required.

When trying to quickly walk through the Java manual instrumentation doc here, I found a series of issues even I haven't completely walked it through yet:

  1. Since it's with Spring Boot 3.x, we should explicitly mention that JDK v17 is the minimum version required. I'd highly suggest to have a dedicated "prerequisites" section so that the reader knows what must be ready before walking through the tutorial.
  2. The example dice app uses mavenCentral(), and defines io.opentelemetry:opentelemetry-semconv:1.34.1-alpha as one of the dependencies, but actually the latest version in Maven Central of that lib is 1.30.1-alpha. Luckily, if we follow carefully we'd realize that it's just some typo thingy as the later section will use the right libs.
  3. Quite some small code errors like the ";" is missing.
  4. The later part of the tutorial is talking something completely different without properly using the example dice app -- if the example app is not good, build another one so the tutorial sticks to it throughout the process.

In short, if it's a reference doc, focus on the capabilities / features and how to use them; if it's a tutorial with a given example, the example must be suitable to demonstrate most, if not all capabilities / features, and then make it a complete workable project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdiscussionInput from everyone is helpful to drive this forwardsig:java

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions