Skip to content

Benchmark page improvements and fixes are needed #4080

Open
@chalin

Description

When the first benchmark pages were introduced, I didn't do a deep dive into the code. I'm seeing now that there are style issues that break Docsy styling, among other things (#3760), but also the way that the page content is structured could be improved. This seem important given that the original benchmark page is being copied for new languages.

  • Simplify HTML used to anchor and rendor the charts
    Consider upgrading to at least Chart v3
    Refactor the JS so that there isn't as much code duplicated across benchmark pages
    Ideally, factor out all the JS code into a JS resource file, if possible

Activity

changed the title Benchmark page template improvement and fixes are needed Benchmark page improvements and fixes are needed on Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @chalin

      Issue actions

        Benchmark page improvements and fixes are needed · Issue #4080 · open-telemetry/opentelemetry.io