-
Notifications
You must be signed in to change notification settings - Fork 1.6k
End user resources webpage update #8980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End user resources webpage update #8980
Conversation
|
@AndrejKiri, I did some testing and previewed in the deploy preview site. Please review the button and let me know. I can see a (Merging is blocked icon, Kindly check that too.) -Thanks, |
AndrejKiri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for accepting the feedback and creating this PR Vidhya! 🙌
Left a few comments. Looking forward to seeing how it renders in the preview instance.
|
|
||
| <a href="https://github.com/orgs/open-telemetry/projects" target="_blank" rel="noopener noreferrer"><button style="background-color:#1e5eb8;color:#f0f6fc;border:none;padding:6px 14px;border-radius:6px;font-weight:600;cursor:pointer;">Review Issues</button></a> | ||
|
|
||
| <!--➡️ TODO: Add a CTA "Review issues" linking to a list of projects in OTel org ) --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this.
| <!--➡️ TODO: Add a CTA "Review issues" linking to a list of projects in OTel org ) --> |
| what we’re looking for. Are you the first person who bumped into this problem? | ||
| File an issue in one of our repositories. | ||
|
|
||
| <a href="https://github.com/orgs/open-telemetry/projects" target="_blank" rel="noopener noreferrer"><button style="background-color:#1e5eb8;color:#f0f6fc;border:none;padding:6px 14px;border-radius:6px;font-weight:600;cursor:pointer;">Review Issues</button></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my surprise, previous link opens the recent projects someone visited what is not always useful. We want to open all the projects. Here is a link to do that:
| <a href="https://github.com/orgs/open-telemetry/projects" target="_blank" rel="noopener noreferrer"><button style="background-color:#1e5eb8;color:#f0f6fc;border:none;padding:6px 14px;border-radius:6px;font-weight:600;cursor:pointer;">Review Issues</button></a> | |
| <a href="https://github.com/orgs/open-telemetry/projects?query=is%3Aopen" target="_blank" rel="noopener noreferrer"><button style="background-color:#1e5eb8;color:#f0f6fc;border:none;padding:6px 14px;border-radius:6px;font-weight:600;cursor:pointer;">Review Issues</button></a> |
| [Join CNCF Slack.](https://communityinviter.com/apps/cloud-native/cncf) | ||
| <a href="https://communityinviter.com/apps/cloud-native/cncf" target="_blank" rel="noopener noreferrer" style="text-decoration:none;display:inline-block;"> <button style="background-color:#1e5eb8;color:#f0f6fc;border:none;padding:6px 12px;border-radius:6px;font-weight:600;cursor:pointer;display:flex;align-items:center;gap:8px;"><span style="order:1;">Join CNCF Slack</span><img src="/img/slack-logo.svg" alt="Slack" style="width:16px;height:16px;order:2;"></button></a> | ||
|
|
||
| <!--➡️ TODO: Turn link to a button --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this as well.
| <!--➡️ TODO: Turn link to a button --> |
|
Btw, when you mentioned that the buttons are Hugo-friendly, I googled that a bit and found also this approach:
Not sure if this would work and I am not suggesting to necessarily use this. Up to you. Just wanted to share something I bumped into. Just FYI that something like that might exist. |
This Slack logo is referred in the button "Join CNCF Slack" in the End User Resources page.
c4854d5 to
ffa9dd5
Compare
|
/fix:all |
|
✅ |
chalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a cleaner way to add CTA buttons:
Sorry, I would have added suggested edits where, but it got a little too much, so I submitted a separate PR>
|
Btw, for future reference, use: as the link to have folks sign up to Slack, not https://communityinviter.com/apps/cloud-native/cncf. |
@AndrejKiri
Following are the changes made as per our discussion in the https://opentelemetry.io/community/end-user/
I have created a Hugo site and tested on this in my local. Please find below the preview of the same.
Please review and let me know.
Thanks
Vidhya
Footnotes
Yes, I can answer maintainer questions about the content of this PR, without using AI. ↩