Skip to content

Commit 6d4c4dc

Browse files
committed
pr review
Signed-off-by: odubajDT <[email protected]>
1 parent e6f616c commit 6d4c4dc

File tree

3 files changed

+31
-4
lines changed

3 files changed

+31
-4
lines changed

docs/non-normative/k8s-migration.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,25 @@ The changes in their attributes are the following:
8585

8686
<!-- prettier-ignore-end -->
8787

88+
### K8s Node allocatable metrics
89+
90+
The K8s node allocatable metrics implemented by the Collector and specifically the
91+
[k8scluster](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.127.0/receiver/k8sclusterreceiver/documentation.md)
92+
receiver.
93+
94+
The changes between collector implementation and semantic conventions:
95+
96+
<!-- prettier-ignore-start -->
97+
98+
| Old (Collector) ![changed](https://img.shields.io/badge/changed-orange?style=flat) | New |
99+
|------------------------------------------------------------------------------------|------------------------------------------------------------------|
100+
| `k8s.node.allocatable_cpu` (type: `gauge`) | `k8s.node.allocatable.cpu` (type: `updowncounter`) |
101+
| `k8s.node.allocatable_memory` (type: `gauge`) | `k8s.node.allocatable.memory` (type: `updowncounter`) |
102+
| `k8s.node.allocatable_ephemeral_storage` (type: `gauge`) | `k8s.node.allocatable.ephemeral_storage` (type: `updowncounter`) |
103+
| `k8s.node.allocatable_pods` (type: `gauge`) | `k8s.node.allocatable.pods` (type: `updowncounter`) |
104+
105+
<!-- prettier-ignore-end -->
106+
88107
### K8s Deployment metrics
89108

90109
The K8s Deployment metrics implemented by the Collector and specifically the

docs/system/k8s-metrics.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ This metric is [recommended][MetricRecommended].
371371

372372
| Name | Instrument Type | Unit (UCUM) | Description | Stability | Entity Associations |
373373
| -------- | --------------- | ----------- | -------------- | --------- | ------ |
374-
| `k8s.node.allocatable.cpu` | UpDownCounter | `{cpu}` | Amount of cpu allocatable on the node | ![Development](https://img.shields.io/badge/-development-blue) | |
374+
| `k8s.node.allocatable.cpu` | UpDownCounter | `{cpu}` | Amount of cpu allocatable on the node | ![Development](https://img.shields.io/badge/-development-blue) | `k8s.node` |
375375

376376
<!-- markdownlint-restore -->
377377
<!-- prettier-ignore-end -->
@@ -391,7 +391,7 @@ This metric is [recommended][MetricRecommended].
391391

392392
| Name | Instrument Type | Unit (UCUM) | Description | Stability | Entity Associations |
393393
| -------- | --------------- | ----------- | -------------- | --------- | ------ |
394-
| `k8s.node.allocatable.memory` | UpDownCounter | `By` | Amount of memory allocatable on the node | ![Development](https://img.shields.io/badge/-development-blue) | |
394+
| `k8s.node.allocatable.memory` | UpDownCounter | `By` | Amount of memory allocatable on the node | ![Development](https://img.shields.io/badge/-development-blue) | `k8s.node` |
395395

396396
<!-- markdownlint-restore -->
397397
<!-- prettier-ignore-end -->
@@ -411,7 +411,7 @@ This metric is [recommended][MetricRecommended].
411411

412412
| Name | Instrument Type | Unit (UCUM) | Description | Stability | Entity Associations |
413413
| -------- | --------------- | ----------- | -------------- | --------- | ------ |
414-
| `k8s.node.allocatable.ephemeral_storage` | UpDownCounter | `By` | Amount of ephemeral-storage allocatable on the node | ![Development](https://img.shields.io/badge/-development-blue) | |
414+
| `k8s.node.allocatable.ephemeral_storage` | UpDownCounter | `By` | Amount of ephemeral-storage allocatable on the node | ![Development](https://img.shields.io/badge/-development-blue) | `k8s.node` |
415415

416416
<!-- markdownlint-restore -->
417417
<!-- prettier-ignore-end -->
@@ -431,7 +431,7 @@ This metric is [recommended][MetricRecommended].
431431

432432
| Name | Instrument Type | Unit (UCUM) | Description | Stability | Entity Associations |
433433
| -------- | --------------- | ----------- | -------------- | --------- | ------ |
434-
| `k8s.node.allocatable.pods` | UpDownCounter | `{pod}` | Amount of pods allocatable on the node | ![Development](https://img.shields.io/badge/-development-blue) | |
434+
| `k8s.node.allocatable.pods` | UpDownCounter | `{pod}` | Amount of pods allocatable on the node | ![Development](https://img.shields.io/badge/-development-blue) | `k8s.node` |
435435

436436
<!-- markdownlint-restore -->
437437
<!-- prettier-ignore-end -->

model/k8s/metrics.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,27 +107,35 @@ groups:
107107
metric_name: k8s.node.allocatable.cpu
108108
stability: development
109109
brief: "Amount of cpu allocatable on the node"
110+
entity_associations:
111+
- k8s.node
110112
instrument: updowncounter
111113
unit: "{cpu}"
112114
- id: metric.k8s.node.allocatable.ephemeral_storage
113115
type: metric
114116
metric_name: k8s.node.allocatable.ephemeral_storage
115117
stability: development
116118
brief: "Amount of ephemeral-storage allocatable on the node"
119+
entity_associations:
120+
- k8s.node
117121
instrument: updowncounter
118122
unit: "By"
119123
- id: metric.k8s.node.allocatable.memory
120124
type: metric
121125
metric_name: k8s.node.allocatable.memory
122126
stability: development
123127
brief: "Amount of memory allocatable on the node"
128+
entity_associations:
129+
- k8s.node
124130
instrument: updowncounter
125131
unit: "By"
126132
- id: metric.k8s.node.allocatable.pods
127133
type: metric
128134
metric_name: k8s.node.allocatable.pods
129135
stability: development
130136
brief: "Amount of pods allocatable on the node"
137+
entity_associations:
138+
- k8s.node
131139
instrument: updowncounter
132140
unit: "{pod}"
133141
# k8s.node.cpu.* metrics

0 commit comments

Comments
 (0)