Skip to content

Commit cd5b45c

Browse files
lmolkovatraskarminru
authored
Deprecate per-rpc status code attributes in favor of rpc.response.status_code (#2920)
Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Armin Ruech <[email protected]>
1 parent 494eb91 commit cd5b45c

28 files changed

+588
-628
lines changed

‎.chloggen/rpc-status-code.yaml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
change_type: breaking
2+
component: rpc
3+
note: >
4+
Deprecate `rpc.grpc.status_code`, `rpc.connect_rpc.error_code` and `rpc.jsonrpc.error_code` attributes
5+
in favor of the more general `rpc.response.status_code` attribute.
6+
issues: [1504, 2920]

‎docs/cicd/cicd-metrics.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ additional filters are applied.
9292

9393
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
9494

95-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
95+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
9696
it's RECOMMENDED to:
9797

9898
- Use a domain-specific attribute
@@ -239,7 +239,7 @@ additional filters are applied.
239239

240240
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
241241

242-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
242+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
243243
it's RECOMMENDED to:
244244

245245
- Use a domain-specific attribute
@@ -293,7 +293,7 @@ additional filters are applied.
293293

294294
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
295295

296-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
296+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
297297
it's RECOMMENDED to:
298298

299299
- Use a domain-specific attribute

‎docs/cicd/cicd-spans.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ additional filters are applied.
7070

7171
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
7272

73-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
73+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
7474
it's RECOMMENDED to:
7575

7676
- Use a domain-specific attribute
@@ -150,7 +150,7 @@ additional filters are applied.
150150

151151
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
152152

153-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
153+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
154154
it's RECOMMENDED to:
155155

156156
- Use a domain-specific attribute

‎docs/cli/cli-spans.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ additional filters are applied.
5555

5656
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
5757

58-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
58+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
5959
it's RECOMMENDED to:
6060

6161
- Use a domain-specific attribute
@@ -118,7 +118,7 @@ additional filters are applied.
118118

119119
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
120120

121-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
121+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
122122
it's RECOMMENDED to:
123123

124124
- Use a domain-specific attribute

‎docs/messaging/azure-messaging.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ additional filters are applied.
9292

9393
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
9494

95-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
95+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
9696
it's RECOMMENDED to:
9797

9898
- Use a domain-specific attribute
@@ -215,7 +215,7 @@ additional filters are applied.
215215

216216
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
217217

218-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
218+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
219219
it's RECOMMENDED to:
220220

221221
- Use a domain-specific attribute

‎docs/messaging/gcp-pubsub.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ additional filters are applied.
8888

8989
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
9090

91-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
91+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
9292
it's RECOMMENDED to:
9393

9494
- Use a domain-specific attribute

‎docs/messaging/kafka.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ additional filters are applied.
8989

9090
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
9191

92-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
92+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
9393
it's RECOMMENDED to:
9494

9595
- Use a domain-specific attribute

‎docs/messaging/messaging-metrics.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ additional filters are applied.
101101

102102
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
103103

104-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
104+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
105105
it's RECOMMENDED to:
106106

107107
- Use a domain-specific attribute
@@ -213,7 +213,7 @@ additional filters are applied.
213213

214214
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
215215

216-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
216+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
217217
it's RECOMMENDED to:
218218

219219
- Use a domain-specific attribute
@@ -310,7 +310,7 @@ additional filters are applied.
310310

311311
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
312312

313-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
313+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
314314
it's RECOMMENDED to:
315315

316316
- Use a domain-specific attribute
@@ -414,7 +414,7 @@ additional filters are applied.
414414

415415
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
416416

417-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
417+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
418418
it's RECOMMENDED to:
419419

420420
- Use a domain-specific attribute

‎docs/messaging/messaging-spans.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ additional filters are applied.
413413

414414
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
415415

416-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
416+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
417417
it's RECOMMENDED to:
418418

419419
- Use a domain-specific attribute

‎docs/messaging/rabbitmq.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ additional filters are applied.
9090

9191
If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.
9292

93-
If a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),
93+
If a specific domain defines its own set of error identifiers (such as HTTP or RPC status codes),
9494
it's RECOMMENDED to:
9595

9696
- Use a domain-specific attribute

0 commit comments

Comments
 (0)