Semantic Convention 1.26.0 has wrong changes description

[sel-bukharov]

Area(s)

area:db, schema

What's the problem?

I got wrong behavior when trying to use schemaprocessor for transition my db metrics to 1.37.0 semantic convention. The problem is 1.25.0 -> 1.26.0 conversation has no effect for renaming labels, only renames metrics.

Name of metric has been converted db.client.connections.usage -> db.client.connection.count but labels has no changes.

NumberDataPoints #0
Data point attributes:
     -> pool.name: Str(mysql+pymysql://db:3306/my_cool_database)
     -> state: Str(idle)

Probably the problem is wrong section apply_to_metrics.

  1.26.0:
    metrics:
      changes:
        # https://github.com/open-telemetry/semantic-conventions/pull/966
        - rename_metrics:
            db.client.connections.usage: db.client.connection.count
            db.client.connections.idle.max: db.client.connection.idle.max
            db.client.connections.idle.min: db.client.connection.idle.min
            db.client.connections.max: db.client.connection.max
            db.client.connections.pending_requests: db.client.connection.pending_requests
            db.client.connections.timeouts: db.client.connection.timeouts
...
        # https://github.com/open-telemetry/semantic-conventions/pull/909
        - rename_attributes:
            attribute_map:
              state: db.client.connections.state
            apply_to_metrics:
              - db.client.connections.usage
        - rename_attributes:
            attribute_map:
              pool.name: db.client.connections.pool.name
            apply_to_metrics:
              - db.client.connections.usage
              - db.client.connections.idle.max
              - db.client.connections.idle.min
              - db.client.connections.max
              - db.client.connections.pending_requests
              - db.client.connections.timeouts
              - db.client.connections.create_time
              - db.client.connections.wait_time
              - db.client.connections.use_time

After applying rename_metrics it should use new names db.client.connection.count etc.

Describe the solution you'd like

Changes described correctly and transitions applies to labels.

Tip

_{React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.}