Clarify `db.query.summary` for batch queries

[trask]

Case 1 (simple)

Given a batch query of

• insert into table1 values (1)
• insert into table1 values (2)

db.query.summary is the same for each of the queries in the batch (insert table1).

I think that db.query.summary in this case should be BATCH insert table1.

(matching db.operation.name behavior for batch queries)

Case 2 (harder)

Given a batch query of

• insert into table1 values (1)
• insert into table2 values (2)

db.query.summary is different for each of the queries in the batch (insert table1 and insert table2).

Should db.query.summary for the batch be:

• BATCH (matching db.operation.name behavior), or
• not reported

Pros to reporting BATCH

• If you're already db.query.summary on other queries, it's nice to have some value for db.query.summary for batch queries since we're envisioning this being a key metric attribute for (some) dashboards
• I'm leaning towards this, sent Clarify db.query.summary for batch queries #3287 to see what it looks like

Pros to not reporting the attribute

• Span name in this case will be only BATCH, while if it was not reported it would fallback to operation.name which happens to be common in this case, and so span name would be the slightly more descriptive BATCH INSERT

[lmolkova]

Span name in this case will be only BATCH, while if it was not reported it would fallback to operation.name which happens to be common in this case, and so span name would be the slightly more descriptive BATCH INSERT

I thought we decided not to populate db.operation.name and db.collection.name for SQL.

The operation name SHOULD NOT be extracted from db.query.text, when the database system supports query text with multiple operations in non-batch operations.

the {operation} we use in https://github.com/trask/semantic-conventions/blob/2cf766b19f0df616b6c4f04c341aa0754eb218c3/docs/db/database-spans.md#generating-a-summary-of-the-query is not really the same as the attribute.

If so, there should be no difference.

---

We could probably say that if operation name is the same in the batch then summary should be BATCH {operation} in the "Generating a summary of the query" section and stop there (we don't care if target is the same, but operations are different). But it seems to be relatively complex and might provide improvements in narrow set of cases.

Anyway, I'm fine with #3287

[trask]

I thought we decided not to populate db.operation.name and db.collection.name for SQL.

🤦‍♂️

Closing, I think that makes this a non-issue for me, will re-open if I find different.