Skip to content

Should db.query.summary normalize case for SQL operations? #3296

@trask

Description

@trask

From https://github.com/open-telemetry/semantic-conventions/blob/main/docs/db/database-spans.md#generating-a-summary-of-the-query:

Instrumentations SHOULD capture the values of operations and targets as provided by the application without attempting to do any case normalization.

I'm having second thoughts about this in the context of SQL, where we know operations are case insensitive and it could be odd to see both SELECT table1 and select table1 in metric dashboards.

While you'd still see both SELECT table1 and SELECT TABLE1 in metric dashboards, that's more easily justifiable given that table names are case sensitive in some SQL databases some of the time.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Need triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions