Merge pull request #338 from open-uem/task-337

task: fix some go suggestions

Author: doncicuto

internal/views/agents_views/agents.templ

@@ -437,7 +437,7 @@ templ AgentsTableBody(p partials.PaginationAndSort, agents []*ent.Agent, tags []
 							<uk-icon hx-history="false" icon="monitor-pause" custom-class="h-7 w-7 text-orange-600" uk-cloack></uk-icon>
 						</div>
 					case "Enabled":
-						if (time.Now().Sub(agent.LastContact).Hours()) > 24 {
+						if (time.Since(time.Now()).Hours()) > 24 {
 							<div class="h-7 w-7" uk-tooltip={ i18n.T(ctx, "No Contact") }>
 								<uk-icon hx-history="false" icon="monitor-x" custom-class="h-7 w-7 text-red-600" uk-cloack></uk-icon>
 							</div>
@@ -618,7 +618,7 @@ type LogEntry struct {
 }
 
 templ AgentsLog(c echo.Context, agent *ent.Agent, agentLog, updaterLog []LogEntry, category, successMessage, errMessage string, refresh int, commonInfo *partials.CommonInfo) {
-	@partials.Header(c, []partials.Breadcrumb{{Title: "Agents", Url: string(templ.URL(partials.GetNavigationUrl(commonInfo, "/agents")))}, {Title: agent.Nickname, Url: string(templ.URL(partials.GetNavigationUrl(commonInfo, fmt.Sprintf("/agents"))))}, {Title: "logs"}}, commonInfo)
+	@partials.Header(c, []partials.Breadcrumb{{Title: "Agents", Url: string(templ.URL(partials.GetNavigationUrl(commonInfo, "/agents")))}, {Title: agent.Nickname, Url: string(templ.URL(partials.GetNavigationUrl(commonInfo, "/agents")))}, {Title: "logs"}}, commonInfo)
 	<main class="grid flex-1 items-start gap-4 p-4 sm:px-6 sm:py-0 md:gap-8">
 		<div id="error" class="hidden"></div>
 		<div class="uk-width-1-2@m uk-card uk-card-default">
@@ -688,7 +688,7 @@ templ AgentsLog(c echo.Context, agent *ent.Agent, agentLog, updaterLog []LogEntr
 }
 
 templ AgentSettings(c echo.Context, agent *ent.Agent, successMessage, errMessage string, refresh int, commonInfo *partials.CommonInfo) {
-	@partials.Header(c, []partials.Breadcrumb{{Title: "Agents", Url: string(templ.URL(partials.GetNavigationUrl(commonInfo, "/agents")))}, {Title: agent.Nickname, Url: string(templ.URL(partials.GetNavigationUrl(commonInfo, fmt.Sprintf("/agents"))))}, {Title: i18n.T(ctx, "Settings")}}, commonInfo)
+	@partials.Header(c, []partials.Breadcrumb{{Title: "Agents", Url: string(templ.URL(partials.GetNavigationUrl(commonInfo, "/agents")))}, {Title: agent.Nickname, Url: string(templ.URL(partials.GetNavigationUrl(commonInfo, "/agents")))}, {Title: i18n.T(ctx, "Settings")}}, commonInfo)
 	<main class="grid flex-1 items-start gap-4 p-4 sm:px-6 sm:py-0 md:gap-8">
 		if successMessage != "" {
 			@partials.SuccessMessage(successMessage)

internal/views/computers_views/computers_views.templ

@@ -144,7 +144,7 @@ templ ComputersBody(p partials.PaginationAndSort, agents []models.Computer, avai
 			>
 				<div class="flex items-center gap-2">
 					<span class="underline">{ agent.Nickname }</span>
-					if (time.Now().Sub(agent.LastContact).Hours()) > 24 {
+					if (time.Since(time.Now()).Hours()) > 24 {
 						<div uk-tooltip={ i18n.T(ctx, "agents.no_contact_in_last_day") }>
 							<uk-icon hx-history="false" icon="clock-8" custom-class="h-5 w-5 text-red-600" uk-cloack></uk-icon>
 						</div>

internal/views/deploy_views/deploy_views.templ

@@ -110,7 +110,7 @@ templ DeployNavbar(active string, commonInfo *partials.CommonInfo) {
 		<li class={ templ.KV("uk-active", active == "install") }>
 			<a
 				href={ templ.URL(partials.GetNavigationUrl(commonInfo, "/deploy/install")) }
-				hx-get={ string(templ.URL(partials.GetNavigationUrl(commonInfo, fmt.Sprintf("/deploy/install")))) }
+				hx-get={ string(templ.URL(partials.GetNavigationUrl(commonInfo, "/deploy/install"))) }
 				hx-push-url="true"
 				hx-target="#main"
 				hx-swap="outerHTML"

internal/views/profiles_views/profiles_edit.templ

@@ -70,14 +70,14 @@ templ EditProfile(c echo.Context, p partials.PaginationAndSort, profile *ent.Pro
                                     end
                                 "
 									>
-										<option value={ "dontApplyToAll" } selected?={ !profile.ApplyToAll && (profile.Edges.Tags == nil || len(profile.Edges.Tags) == 0) }>{ i18n.T(ctx, "profiles.dont_assign") }</option>
+										<option value={ "dontApplyToAll" } selected?={ !profile.ApplyToAll && len(profile.Edges.Tags) == 0 }>{ i18n.T(ctx, "profiles.dont_assign") }</option>
 										<option value={ "applyToAll" } selected?={ profile.ApplyToAll }>{ i18n.T(ctx, "profiles.assign_all") }</option>
-										<option value={ "useTags" } selected?={ profile.Edges.Tags != nil && len(profile.Edges.Tags) > 0 }>{ i18n.T(ctx, "profiles.assign_tags") }</option>
+										<option value={ "useTags" } selected?={ len(profile.Edges.Tags) > 0 }>{ i18n.T(ctx, "profiles.assign_tags") }</option>
 									</select>
 								</div>
 							</div>
 							<div>
-								<div id="profile-tags" class={ templ.KV("invisible", profile.Edges.Tags == nil || len(profile.Edges.Tags) == 0), templ.KV("visible", len(profile.Edges.Tags) > 0) }>
+								<div id="profile-tags" class={ templ.KV("invisible", len(profile.Edges.Tags) == 0), templ.KV("visible", len(profile.Edges.Tags) > 0) }>
 									<label class="uk-form-label" for="profile-tags-section">
 										{ i18n.T(ctx, "profiles.edit.select_tags") }
 									</label>
@@ -115,7 +115,7 @@ templ EditProfile(c echo.Context, p partials.PaginationAndSort, profile *ent.Pro
 							</button>
 						</div>
 					</div>
-					if profile.Edges.Tasks == nil || len(profile.Edges.Tasks) == 0 {
+					if len(profile.Edges.Tasks) == 0 {
 						<p class="uk-text-small uk-text-muted">
 							{ i18n.T(ctx, "profiles.edit.no_tasks") }
 						</p>

internal/views/profiles_views/profiles_views.templ

@@ -91,7 +91,7 @@ templ Profiles(c echo.Context, p partials.PaginationAndSort, profiles []*ent.Pro
 									if profile.ApplyToAll {
 										@ShowAppliedToAll()
 									} else {
-										if profile.Edges.Tags != nil && len(profile.Edges.Tags) > 0 {
+										if len(profile.Edges.Tags) > 0 {
 											@partials.ShowAppliedTagsWithoutRemoveOption(profile.Edges.Tags)
 										} else {
 											@ShowAppliedToNone()