Skip to content

Commit 16f4336

Browse files
committed
fix(ci): make vela_*.bin copy optional in artifact backup
The artifact backup step in ci-tasks tried to copy cmake_out/*/vela_*.bin for every non-vendor task, but only full-image configs (goldfish) actually produce vela_*.bin. Configs like qemu-* only produce the nuttx ELF, so the glob resolves to a literal path, cp fails with 'No such file or directory', and the whole matrix job is marked failed even though the build succeeded. This latent bug was only exposed after #58 introduced qemu builds to the matrix. Fix: always copy nuttx and .config, then attempt to copy vela_*.bin separately with '|| true' so missing binaries are ignored. Seen in: https://github.com/open-vela/packages_fe_examples/actions/runs/25427679424/job/74586459600
1 parent 14d267f commit 16f4336

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,10 @@ jobs:
493493
if [[ "$task" == *:* ]] || [[ "$task" == *vendor/* ]]; then
494494
cp ${cp_base_dir}/nuttx ${cp_base_dir}/.config $ci_artifact_name
495495
else
496-
cp ${cp_base_dir}/nuttx ${cp_base_dir}/vela_*.bin ${cp_base_dir}/.config $ci_artifact_name
496+
cp ${cp_base_dir}/nuttx ${cp_base_dir}/.config $ci_artifact_name
497+
# vela_*.bin is optional: only produced by full-image configs
498+
# (e.g. goldfish). Configs like qemu-* only produce nuttx ELF.
499+
cp ${cp_base_dir}/vela_*.bin $ci_artifact_name 2>/dev/null || true
497500
fi
498501
499502
echo "=== Cleaning up after $task ==="

0 commit comments

Comments
 (0)