refac

Author: tjbck

README.md

@@ -65,21 +65,21 @@ Output streams as JSONL:
 
 **From URL:**
 ```bash
-curl -X POST "http://localhost:8000/files/upload?url=https://example.com/data.csv&path=/tmp/data.csv" \
+curl -X POST "http://localhost:8000/files/upload?url=https://example.com/data.csv&dir=/tmp" \
   -H "Authorization: Bearer <api-key>"
 ```
 
 **Direct upload:**
 ```bash
-curl -X POST "http://localhost:8000/files/upload?path=/tmp/data.csv" \
+curl -X POST "http://localhost:8000/files/upload?dir=/tmp" \
   -H "Authorization: Bearer <api-key>" \
   -F "file=@local_file.csv"
 ```
 
 **Via temporary link (no auth needed to upload):**
 ```bash
 # 1. Generate an upload link
-curl -X POST "http://localhost:8000/files/upload/link?path=/tmp/data.csv" \
+curl -X POST "http://localhost:8000/files/upload/link?dir=/tmp" \
   -H "Authorization: Bearer <api-key>"
 # → {"url": "http://localhost:8000/files/upload/a1b2c3d4..."}
 
@@ -88,6 +88,8 @@ curl -X POST "http://localhost:8000/files/upload/a1b2c3d4..." \
   -F "file=@local_file.csv"
 ```
 
+Filename is automatically derived from the uploaded file or URL.
+
 ### Download a File
 
 ```bash

open_terminal/main.py

@@ -132,23 +132,27 @@ async def download_file(token: str):
     },
 )
 async def upload_file(
-    path: str = Query(..., description="Absolute destination path for the file."),
+    dir: str = Query(..., description="Destination directory for the file."),
     url: Optional[str] = Query(None, description="URL to download the file from. If omitted, expects a multipart file upload."),
     file: Optional[UploadFile] = File(None, description="The file to upload (if no URL provided)."),
 ):
     if url:
         import httpx
+        from urllib.parse import urlparse
 
         async with httpx.AsyncClient(follow_redirects=True) as client:
             resp = await client.get(url)
             resp.raise_for_status()
         content = resp.content
+        filename = os.path.basename(urlparse(url).path) or "download"
     elif file:
         content = await file.read()
+        filename = file.filename or "upload"
     else:
         raise HTTPException(status_code=400, detail="Provide either 'url' or a file upload.")
 
-    os.makedirs(os.path.dirname(path), exist_ok=True)
+    os.makedirs(dir, exist_ok=True)
+    path = os.path.join(dir, filename)
     with open(path, "wb") as f:
         f.write(content)
     return {"path": path, "size": len(content)}
@@ -164,14 +168,14 @@ async def upload_file(
     },
 )
 async def create_upload_link(
-    path: str = Query(..., description="Absolute destination path for the uploaded file."),
+    dir: str = Query(..., description="Destination directory for the uploaded file."),
     request: Request = None,
 ):
     import time
     import uuid
 
     token = uuid.uuid4().hex
-    _upload_links[token] = (path, time.time() + 300)
+    _upload_links[token] = (dir, time.time() + 300)
 
     base_url = str(request.base_url).rstrip("/")
     return {"url": f"{base_url}/files/upload/{token}"}
@@ -211,11 +215,13 @@ async def upload_file_via_link(
     if not entry:
         raise HTTPException(status_code=404, detail="Invalid or expired upload link")
 
-    path, expiry = entry
+    dir, expiry = entry
     if time.time() > expiry:
         raise HTTPException(status_code=404, detail="Upload link expired")
 
-    os.makedirs(os.path.dirname(path), exist_ok=True)
+    filename = file.filename or "upload"
+    os.makedirs(dir, exist_ok=True)
+    path = os.path.join(dir, filename)
     content = await file.read()
     with open(path, "wb") as f:
         f.write(content)

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "open-terminal"
-version = "0.1.7"
+version = "0.1.8"
 description = "A minimal terminal interaction API"
 readme = "README.md"
 authors = [