Skip to content

Commit ad0d652

Browse files
committed
refactored fields to have _all suffix instead of all_ prefix.
1 parent 2b29152 commit ad0d652

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

api_v2/models/speed.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def get_speed(self):
6060

6161
return speed
6262

63-
def get_all_speed(self):
63+
def get_speed_all(self):
6464
return {
6565
"unit": self.get_unit(),
6666
"walk": self.walk,

api_v2/serializers/creature.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,13 @@ class CreatureSerializer(GameContentSerializer):
104104
ability_scores = serializers.SerializerMethodField()
105105
modifiers = serializers.SerializerMethodField()
106106
saving_throws = serializers.SerializerMethodField()
107-
all_saving_throws = serializers.SerializerMethodField()
107+
saving_throws_all = serializers.SerializerMethodField()
108108
skill_bonuses = serializers.SerializerMethodField()
109-
all_skill_bonuses = serializers.SerializerMethodField()
109+
skill_bonuses_all = serializers.SerializerMethodField()
110110
actions = serializers.SerializerMethodField()
111111
size = SizeSerializer(read_only=True, context={'request': {}})
112112
speed = serializers.SerializerMethodField()
113-
all_speed = serializers.SerializerMethodField()
113+
speed_all = serializers.SerializerMethodField()
114114
challenge_rating_text = serializers.SerializerMethodField()
115115
experience_points = serializers.SerializerMethodField()
116116

@@ -125,7 +125,7 @@ class Meta:
125125
'name',
126126
'size',
127127
'speed',
128-
'all_speed',
128+
'speed_all',
129129
'category',
130130
'type',
131131
'alignment',
@@ -139,9 +139,9 @@ class Meta:
139139
'ability_scores',
140140
'modifiers',
141141
'saving_throws',
142-
'all_saving_throws',
142+
'saving_throws_all',
143143
'skill_bonuses',
144-
'all_skill_bonuses',
144+
'skill_bonuses_all',
145145
'passive_perception',
146146
'damage_immunities',
147147
'nonmagical_attack_immunity',
@@ -171,7 +171,7 @@ def get_saving_throws(self, creature):
171171
entries = creature.get_saving_throws().items()
172172
return { key: value for key, value in entries if value is not None }
173173

174-
def get_all_saving_throws(self, creature):
174+
def get_saving_throws_all(self, creature):
175175
'''Implicit saving throws helper method.'''
176176
defaults = creature.get_modifiers()
177177
entries = creature.get_saving_throws().items()
@@ -182,7 +182,7 @@ def get_skill_bonuses(self, creature):
182182
entries = creature.get_skill_bonuses().items()
183183
return { key: value for key, value in entries if value is not None }
184184

185-
def get_all_skill_bonuses(self, creature):
185+
def get_skill_bonuses_all(self, creature):
186186
'''Implicit skill bonuses helper method.'''
187187
defaults = {
188188
'acrobatics': creature.modifier_dexterity,
@@ -212,9 +212,9 @@ def get_speed(self, creature):
212212
entries = creature.get_speed().items()
213213
return { key: value for key, value in entries if value is not None }
214214

215-
def get_all_speed(self, creature):
215+
def get_speed_all(self, creature):
216216
'''Implicit speed helper method.'''
217-
return creature.get_all_speed()
217+
return creature.get_speed_all()
218218

219219
def get_actions(self, creature):
220220
'''Actions helper method.'''

0 commit comments

Comments
 (0)