[BUG] Inconsistent data between v1 and v2

[postrowski]

Describe the bug
I have an application that reads in both the v1/monsters and the v2/creatures, then puts them into a common object format, and compares them. I'm finding a lot of inconsistencies between the data for specific monsters (comparing only the 'wotc-srd' source from v1/monsters against the 'srd-2014' source from v2/creatures).
Generally speaking these are the errors in the v2/creatures:

1. many of the actions do not have proper 'usage_limits' on them (such as recharge on roll, or short/long rest).
2. Many creatures do not have a 'desc' member filled in.
3. Many creatures list a climb speed and a swim speed that doesn't exist in the v1/monster, and doesn't seem right.
4. A few v1/monsters had special notes in the speed object that isn't present in the v2/creatures
5. Many v2/creatures don't list any spells that exist in the v1/monster.spell_list array.
6. Many v2/creatures don't list a subtype that was present in the v1/monster.subtype.
7. A couple v2/creatures (Grimlock & Wererat) have incomplete senses when compaired to their v1/monster match.
8. A few v2/creatures (Mastiff, Lich, Half-Red Dragon Veteran & Werewolf) have inconsistent skill levels.
9. Minor changes (not sure which one is correct):
   a) Basilisk has different ACs (15 vs. 12)
   b) Chain Devil has charisma_save, constitution_save & wisdom_save that didn't exist in v1/monster
   c) Skeleton 'poison resistance' in v1/monsters became 'poison immunity' in v2/creatures.
   d) Doppelganger alignment changed from unaligned in v1/monsters to neutral in v2/creatures.

To Reproduce
Steps to reproduce the behavior:
Download each of the monsters from v1/monsters, and compare them against the same monster in v2/creatures
...

Expected behavior
The data should match closely.

Hardware (please complete the following information):

• Device: Windows Laptop
• OS: Windows 11
• Browser Chrome

Additional context
I have attached a spreadsheet with all the fields that differ between the endpoints.

open5eBugs.xlsx

[calumbell]

Hey @postrowski, thanks for flagging these. So I have taken a look at your notes and a perfunctory peak at the spreadsheet (lots of data to parse there!). Here are my thoughts:

1. The usage_limits is left blank when there are no limitations to an actions usage. I'll take a peak through the attached document to see if there are any errors in this data.

2. The desc fields for all srd-2014 monsters will be blank because the monster descriptions from the PHB are not included in SRD 5.1. This field does see some use in monsters from other sources. EDIT: Except those statblocks from Appendix MM-B: Nonplayer Characters, we should add those in!

3. These additional speeds are inferred based on rules (ie. crawling being half your walk speed). I believe that the intended use is for people creating VTTs, but I agree that it does look weird. It is probably worth discussing trimming these down to only speeds listed in the stat-block.

4. Ah like different speeds in different forms, stuff like that? If we don't support that then we should, will likely require a little API upgrade.

5. V2 handles monster spell lists in a different way to V1. Spellcasting details can be found in the "traits" array for spellcasting monsters

6. Good spot, will investigate. EDIT: it doesn't look like we have a field to support this data yet. Opened [BUG] Add missing subtype field to Creature model #936 to tackle.

7. As above

8. Oh yeah, those are a mess. Will look into it. EDIT: only the Mastiff is a mess, the others have skill levels consistant with their 5.1 SRD representation

9a-d) Checked all of these against the SRD 5.1. In all of these examples the V2 data correctly reflects, the errors are in the V1 data not correctly reflecting the source document.

I'll investigate a little closer and then likely open some sub-issues. Thanks for bringing these to our attention (And thanks for numbering your points, makes responding so much easier!)

[calumbell]

(Transferred this issue to the Open5e API repo because that is where the data lives)