Skip to content

Keyboard might overlap with video player in side by side mode #825

Open
@mathebox

Description

@mathebox

Describe the bug
When in side-by-side mode and the keyboard is shown, the keyboard overlaps with the shown video.

To Reproduce
Steps to reproduce the behavior:

  1. Open a video item
  2. Switch to side-by-side mode with Notes app
  3. Tap into the notes canvas to show the keyboard
  4. Notice overlapping keyboard and video player

Expected behavior
Move the video up to show as much of the video as possible.

Screenshots
IMG_FCB5388DF46F-1

Affected Component
BingePlayerViewController

Additional context

  • Observe UIResponder.keyboardWillShowNotification and UIResponder.keyboardWillHideNotification to react accordingly.
  • Retrieve height for keyboard via

    let keyboardFrameValue = notification.userInfo[UIResponder.keyboardFrameEndUserInfoKey] as? NSValuelet keyboardHeight = keyboardFrameValue?.cgRectValue.size.height

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions