Skip to content

Commit c87894e

Browse files
committed
fixing linking behavior of numeric attribtues (which should be embedded) vs non-numeric attributes (which should be linked)
1 parent 8b5dd3e commit c87894e

File tree

4 files changed

+37
-19
lines changed

4 files changed

+37
-19
lines changed
Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,33 @@
11
{
22
"_type": "core:TissueSampleCollectionStateStatistic",
33
"required": [
4-
"attribute",
54
"count"
65
],
76
"properties": {
8-
"attribute": {
7+
"count": {
8+
"type": "integer",
9+
"_instruction": "Enter the tissue sample count within the tissue sample collection to which the defined state attribute(s) apply.",
10+
},
11+
"qualitativeCharacteristic": {
912
"type": "array",
1013
"minItems": 1,
1114
"uniqueItems": true,
12-
"_instruction": "Add all attributes (including age) common for the specified tissue sample count within the tissue sample collection state.",
15+
"_instruction": "Add all qualitative characteristics common for the specified tissue sample count within the tissue sample collection state.",
1316
"_linkedTypes": [
1417
"controlledTerms:Disease",
1518
"controlledTerms:DiseaseModel",
16-
"controlledTerms:TissueSampleAttribute",
19+
"controlledTerms:TissueSampleAttribute"
20+
]
21+
},
22+
"quantitativeMeasurement": {
23+
"type": "array",
24+
"minItems": 1,
25+
"uniqueItems": true,
26+
"_instruction": "Add all quantitative measurements common for the specified tissue sample count within the tissue sample collection state.",
27+
"_embeddedTypes": [
1728
"core:SpecimenAge",
1829
"core:SpecimenWeight"
1930
]
20-
},
21-
"count": {
22-
"type": "integer",
23-
"_instruction": "Enter the tissue sample count within the tissue sample collection to which the defined state attribute(s) apply.",
24-
}
31+
}
2532
}
2633
}
Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,34 @@
11
{
22
"_type": "core:SubjectGroupStateStatistic",
33
"required": [
4-
"attribute",
54
"count"
65
],
76
"properties": {
8-
"attribute": {
7+
"count": {
8+
"type": "integer",
9+
"_instruction": "Enter the subject count within the subject group to which the defined state attribute(s) (composed of qualitative characteristic(s) and/or quantitative measurement(s)) apply.",
10+
},
11+
"qualitativeCharacteristic": {
912
"type": "array",
1013
"minItems": 1,
1114
"uniqueItems": true,
12-
"_instruction": "Add all attributes (including age) common for the specified subject count within the subject group state.",
15+
"_instruction": "Add all qualitative characteristics common for the specified subject count within the subject group state.",
1316
"_linkedTypes": [
1417
"controlledTerms:AgeCategory",
1518
"controlledTerms:Disease",
1619
"controlledTerms:DiseaseModel",
17-
"controlledTerms:SubjectAttribute",
20+
"controlledTerms:SubjectAttribute"
21+
]
22+
},
23+
"quantitativeMeasurement": {
24+
"type": "array",
25+
"minItems": 1,
26+
"uniqueItems": true,
27+
"_instruction": "Add all quantitative measurements common for the specified subject count within the subject group state.",
28+
"_embeddedTypes": [
1829
"core:SpecimenAge",
1930
"core:SpecimenWeight"
2031
]
21-
},
22-
"count": {
23-
"type": "integer",
24-
"_instruction": "Enter the subject count within the subject group to which the defined state attribute(s) apply.",
2532
}
2633
}
2734
}

schemas/research/subjectGroupStatistic.schema.tpl.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
"uniqueItems": true,
1212
"_instruction": "Add all attributes common for the specified subject count within the subject group.",
1313
"_linkedTypes": [
14-
"controlledTerms:SpecimenAttribute"
14+
"controlledTerms:BiologicalSex",
15+
"controlledTerms:Species",
16+
"controlledTerms:Strain"
1517
]
1618
},
1719
"count": {

schemas/research/tissueSampleCollectionStatistic.schema.tpl.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
"uniqueItems": true,
1212
"_instruction": "Add all attributes common for the specified tissue sample count within the tissue sample collection.",
1313
"_linkedTypes": [
14-
"controlledTerms:SpecimenAttribute",
14+
"controlledTerms:BiologicalSex",
15+
"controlledTerms:Species",
16+
"controlledTerms:Strain",
1517
"core:TissueSampleIdentity"
1618
]
1719
},

0 commit comments

Comments
 (0)