More lenient string conversion

Author: franzpoeschel

include/openPMD/auxiliary/JSON.hpp

@@ -181,5 +181,9 @@ namespace json
 #endif
 
     nlohmann::json & lowerCase( nlohmann::json & );
+
+    std::string asStringDynamic( nlohmann::json const & );
+
+    std::string asLowerCaseStringDynamic( nlohmann::json const & );
 } // namespace json
 } // namespace openPMD

src/IO/ADIOS/ADIOS2IOHandler.cpp

@@ -140,12 +140,8 @@ ADIOS2IOHandlerImpl::init( nlohmann::json cfg )
             if( !engineTypeConfig.is_null() )
             {
                 // convert to string
-                m_engineType = engineTypeConfig;
-                std::transform(
-                    m_engineType.begin(),
-                    m_engineType.end(),
-                    m_engineType.begin(),
-                    []( unsigned char c ) { return std::tolower( c ); } );
+                m_engineType =
+                    json::asLowerCaseStringDynamic( engineTypeConfig );
             }
         }
         auto operators = getOperators();
@@ -189,7 +185,7 @@ ADIOS2IOHandlerImpl::getOperators( json::TracingJSON cfg )
                  ++paramIterator )
             {
                 adiosParams[ paramIterator.key() ] =
-                    paramIterator.value().get< std::string >();
+                    json::asStringDynamic( paramIterator.value() );
             }
         }
         auxiliary::Option< adios2::Operator > adiosOperator =
@@ -2318,7 +2314,8 @@ namespace detail
                 for( auto it = params.json().begin(); it != params.json().end();
                      it++ )
                 {
-                    m_IO.SetParameter( it.key(), it.value() );
+                    m_IO.SetParameter(
+                        it.key(), json::asStringDynamic( it.value() ) );
                     alreadyConfigured.emplace( it.key() );
                 }
             }

src/IO/HDF5/HDF5IOHandler.cpp

@@ -97,7 +97,8 @@ HDF5IOHandlerImpl::HDF5IOHandlerImpl(
             auto datasetConfig = m_config[ "dataset" ];
             if( datasetConfig.json().contains( "chunks" ) )
             {
-                m_chunks = datasetConfig[ "chunks" ].json().get< std::string >();
+                m_chunks = json::asLowerCaseStringDynamic(
+                    datasetConfig[ "chunks" ].json() );
             }
         }
         if( m_chunks != "auto" && m_chunks != "none" )

src/auxiliary/JSON.cpp

@@ -231,5 +231,31 @@ namespace json
         }
         return json;
     }
+
+    std::string asStringDynamic( nlohmann::json const & value )
+    {
+        if( value.is_string() )
+        {
+            return value.get< std::string >();
+        }
+        else if( value.is_number_integer() )
+        {
+            return std::to_string( value.get< long long >() );
+        }
+        else if( value.is_number_float() )
+        {
+            return std::to_string( value.get< long double >() );
+        }
+        else if( value.is_boolean() )
+        {
+            return value.get< bool >() ? "1" : "0";
+        }
+        throw std::runtime_error( "JSON: Cannot convert value to string." );
+    }
+
+    std::string asLowerCaseStringDynamic( nlohmann::json const & value )
+    {
+        return auxiliary::lowerCase( asStringDynamic( value ) );
+    }
 } // namespace json
 } // namespace openPMD

test/SerialIOTest.cpp

@@ -3134,7 +3134,7 @@ TEST_CASE( "serial_adios2_json_config", "[serial][adios2]" )
       "type": "bp4",
       "unused": "parameter",
       "parameters": {
-        "BufferGrowthFactor": "2.0",
+        "BufferGrowthFactor": 2.0,
         "Profile": "On"
       }
     },
@@ -3144,7 +3144,7 @@ TEST_CASE( "serial_adios2_json_config", "[serial][adios2]" )
         {
           "type": "blosc",
           "parameters": {
-              "clevel": "1",
+              "clevel": 1,
               "doshuffle": "BLOSC_BITSHUFFLE"
           }
         }