Skip to content

Commit ce25526

Browse files
ax3ljeanbezfranzpoeschelpre-commit-ci[bot]
authored
Release 0.14.5 backports (#1282)
* Improve write time * Print warning if mpi4py is not found in openpmd-pipe * ADIOS1: Remove task from IO queue if it fails with exception * `setup.py`: Extra CMake Arg Control * EMSCRIPTEN: Skip Py Extension * g++/clang++: Add `-Wsign-compare` * python/RecordComponent: fix `-Wsign-compare` * Patch MSVC pybind11 bug Improve patch comment * Python: Do Not Strip Symbols In Debug Avoid stripping symbols for Python debug builds, so we can see lines in coredumps and debugger runs. * CI: NVHPC New Apt Repo Update the NVHPC install instructions to the latest and greatest. Fix failing CI (dependency install). Also upgrade to 21.11 as on Perlmutter. * clang-format & pre-commit & python include * run pre-commit * ps_make_timer_name_: add memory leak suppression * Fix: Missing HDF5 Include This tries to fix a compile error on Maxwell (DESY). ``` /home/diederse/software/hipace_4GPU/hipace/build/_deps/fetchedopenpmd-src/src/IO/HDF5/HDF5IOHandler.cpp: In member function 'virtual void openPMD::HDF5IOHandlerImpl::readAttribute(openPMD::Writable*, openPMD::Parameter<openPMD::Operation::READ_ATT>&)': /home/diederse/software/hipace_4GPU/hipace/build/_deps/fetchedopenpmd-src/src/IO/HDF5/HDF5IOHandler.cpp:1586:17: error: 'H5free_memory' was not declared in this scope 1586 | H5free_memory(m1); | ^~~~~~~~~~~~~ /home/diederse/software/hipace_4GPU/hipace/build/_deps/fetchedopenpmd-src/src/IO/HDF5/HDF5IOHandler.cpp:1609:17: error: 'H5free_memory' was not declared in this scope 1609 | H5free_memory(m1); | ^~~~~~~~~~~~~ /home/diederse/software/hipace_4GPU/hipace/build/_deps/fetchedopenpmd-src/src/IO/HDF5/HDF5IOHandler.cpp:1628:17: error: 'H5free_memory' was not declared in this scope 1628 | H5free_memory(m2); | ^~~~~~~~~~~~~ ``` * Increase reference count also in other load_chunk overload Don't know if it is necessary, but looks like we forgot it earlier Add comment * Spack: Remove Old Files * Spack: v0.17.1 * Update Env Files * Python Iteration: Fix __repr__ (time) Small numbers, as common for iterations, were flushed to zero in `std::to_string(double)` of the representation of `Iteration` variables: ``` step __repr__ 100 <openPMD.Iteration at t = '0.000000 s'> was: 8.687655225973454e-14 * 1.0 ``` * CI: Update CUDA repo key Nvidia has made changes in the signing keys. https://forums.developer.nvidia.com/t/notice-cuda-linux-repository-key-rotation/212771 * CI: Switch to Mamba * Doc: Update HDF5 Coll. Metadata Versions Update the documentation about HDFFV-11260 and the newly released fixes in release lines. * HDF5 Coll. MD Reads: Simplify Wording * Tiny wording improvement and a + * Remove deprecated debug parameter in ADIOS2 * HDF5IOHandler: Clang-Format/Clang-Tidy ``` /home/runner/work/openPMD-api/openPMD-api/src/IO/HDF5/HDF5IOHandler.cpp:1835:21: warning: repeated branch in conditional chain [bugprone-branch-clone] isLegacyLibSplashAttr = ^ ``` * `conda.yaml`: add `pre-commit` * Fix: Python Variant Issue on Conda * Test: Demonstrate Pattern Issue As in #1173 * JSON: Improve File Open Error Message Include path to file * Upon parsing, store each iteration's filename If the padding is inconsistent, a later Iteration::open() needs the original filename. Trying to compute the filename from the expansion pattern will lead to wrong filenames. * Backport: fix-open-iteration (#5) * Pass-through flushing parameters * CI fixes * Test * Don't flush when opening an iteration * CI fixes * FlushLevel: Use default base class in NVC++ * clang-tidy: Define member defaults of Writable in-class * Update include/openPMD/IO/AbstractIOHandler.hpp Co-authored-by: Axel Huebl <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Release 0.14.5 conflicting backports (#6) * Don't safeguard empty strings while reading * Update TODO Comment * Add missing update for VEC_CLONG_DOUBLE * Ignore deprecated AccessType in SerialIOTest * SerialIOTest: Fix GCC Pragma Check (#1260) There was a typo in `__GNUC_MINOR__`, causing the test not to work on all GCC versions. Follow-up to #1213 * Clearly fail when users select a wrong backend * ICC: Unreachable end of function * Fix use after free in ADIOS1IOHandler * Remove unavailable_backend_test Hard to trigger without explicit backend selection, and test coverage is present on dev anyway Co-authored-by: Axel Huebl <[email protected]> * Version: 0.14.5 including Changelog Co-authored-by: Jean Luca Bez <[email protected]> Co-authored-by: Franz Pöschel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 756bffc commit ce25526

File tree

241 files changed

+23504
-22325
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

241 files changed

+23504
-22325
lines changed

.clang-format

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
---
2+
Language: Cpp
3+
4+
BasedOnStyle: LLVM
5+
AccessModifierOffset: -4
6+
AlignAfterOpenBracket: AlwaysBreak
7+
AlignConsecutiveAssignments: false
8+
AlignConsecutiveDeclarations: false
9+
# AlignEscapedNewlinesLeft: false
10+
AlignEscapedNewlines: Right
11+
AlignOperands: false
12+
AlignTrailingComments: false
13+
AllowAllArgumentsOnNextLine: true
14+
AllowAllConstructorInitializersOnNextLine: true
15+
AllowAllParametersOfDeclarationOnNextLine: true
16+
AllowShortBlocksOnASingleLine: false
17+
AllowShortCaseLabelsOnASingleLine: false
18+
AllowShortFunctionsOnASingleLine: None
19+
AllowShortIfStatementsOnASingleLine: false
20+
AllowShortLambdasOnASingleLine: true
21+
AllowShortLoopsOnASingleLine: false
22+
AlwaysBreakBeforeMultilineStrings: true
23+
AlwaysBreakTemplateDeclarations: Yes
24+
BinPackArguments: false
25+
BinPackParameters: false
26+
27+
BreakBeforeBraces: Custom
28+
BraceWrapping:
29+
AfterClass: true
30+
AfterControlStatement: true
31+
AfterEnum: true
32+
AfterExternBlock: true
33+
AfterFunction: true
34+
AfterNamespace: true
35+
AfterStruct: true
36+
AfterUnion: true
37+
BeforeCatch: true
38+
BeforeElse: true
39+
# BeforeLambdaBody: true
40+
SplitEmptyFunction: false
41+
SplitEmptyNamespace: false
42+
SplitEmptyRecord: false
43+
44+
BreakConstructorInitializers: BeforeComma
45+
BreakInheritanceList: BeforeComma
46+
ColumnLimit: 80
47+
CompactNamespaces: false
48+
ConstructorInitializerAllOnOneLineOrOnePerLine: true
49+
ConstructorInitializerIndentWidth: 4
50+
ContinuationIndentWidth: 4
51+
FixNamespaceComments: true
52+
IndentWidth: 4
53+
NamespaceIndentation: Inner
54+
PointerAlignment: Right
55+
SortUsingDeclarations: false
56+
SpaceAfterCStyleCast: false
57+
SpaceAfterTemplateKeyword: true
58+
SpaceBeforeAssignmentOperators: true
59+
SpaceBeforeParens: ControlStatements
60+
SpaceInEmptyParentheses: false
61+
SpacesInAngles: false
62+
SpacesInContainerLiterals: false
63+
SpacesInCStyleCastParentheses: false
64+
SpacesInParentheses: false
65+
SpacesInSquareBrackets: false
66+
Standard: Auto
67+
StatementMacros: ["OPENPMD_private", "OPENPMD_protected"]
68+
69+
---
70+
Language: Json
71+
BasedOnStyle: llvm
72+
...

.github/ISSUE_TEMPLATE/install_problem.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ labels: install
55
---
66

77
**Performed steps**
8-
The following steps
8+
The following steps
99

1010
```commandline
1111
...

.github/ci/sanitizer/clang/Leak.supp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,4 @@ leak:adios_inq_var
1515
# ADIOS2
1616
leak:adios2::core::engine::SstReader::*
1717
leak:adios2::core::engine::SstWriter::*
18+
leak:ps_make_timer_name_

.github/ci/spack-envs/clang10_nopy_ompi_h5_ad1_ad2/spack.yaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,26 +20,26 @@ spack:
2020
variants: ~zfp ~sz ~png ~dataman ~python ~fortran ~ssc ~shared ~bzip2
2121
cmake:
2222
externals:
23-
- spec: "cmake"
23+
- spec: cmake@3.23.0
2424
prefix: /usr
2525
buildable: False
2626
openmpi:
2727
externals:
28-
- spec: "openmpi"
28+
- spec: openmpi@2.1.1
2929
prefix: /usr
3030
buildable: False
3131
perl:
3232
externals:
33-
- spec: "perl"
33+
- spec: perl@5.26.1
3434
prefix: /usr
3535
buildable: False
3636
python:
3737
externals:
38-
- spec: "python"
38+
- spec: python@3.8.0
3939
prefix: /usr
4040
buildable: False
4141
all:
42-
target: ['x86_64']
42+
target: [x86_64]
4343
variants: ~fortran
4444
providers:
4545
mpi: [openmpi]
@@ -63,3 +63,5 @@ spack:
6363
config:
6464
build_jobs: 2
6565

66+
mirrors:
67+
E4S: https://cache.e4s.io

.github/ci/spack-envs/clang5_nopy_nompi_h5/spack.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ spack:
1010

1111
packages:
1212
all:
13-
target: ['x86_64']
13+
target: [x86_64]
1414
variants: ~mpi ~fortran
1515
compiler: [[email protected]]
1616

@@ -32,3 +32,5 @@ spack:
3232
config:
3333
build_jobs: 2
3434

35+
mirrors:
36+
E4S: https://cache.e4s.io

.github/ci/spack-envs/clang5_nopy_ompi_h5_ad1_ad2_bp3/spack.yaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,26 +18,26 @@ spack:
1818
variants: ~zfp ~sz ~png ~dataman ~python ~fortran ~ssc ~shared ~bzip2
1919
cmake:
2020
externals:
21-
- spec: "cmake"
21+
- spec: cmake@3.23.0
2222
prefix: /usr
2323
buildable: False
2424
openmpi:
2525
externals:
26-
- spec: "openmpi"
26+
- spec: openmpi@2.1.1
2727
prefix: /usr
2828
buildable: False
2929
perl:
3030
externals:
31-
- spec: "perl"
31+
- spec: perl@5.26.1
3232
prefix: /usr
3333
buildable: False
3434
python:
3535
externals:
36-
- spec: "python"
36+
- spec: python@3.8.0
3737
prefix: /usr
3838
buildable: False
3939
all:
40-
target: ['x86_64']
40+
target: [x86_64]
4141
variants: ~fortran
4242
providers:
4343
mpi: [openmpi]
@@ -61,3 +61,5 @@ spack:
6161
config:
6262
build_jobs: 2
6363

64+
mirrors:
65+
E4S: https://cache.e4s.io

.github/ci/spack-envs/clang8_py38_mpich_h5_ad1_ad2/spack.yaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,26 +18,26 @@ spack:
1818
variants: ~zfp ~sz ~png ~dataman ~python ~fortran ~ssc ~shared ~bzip2
1919
cmake:
2020
externals:
21-
- spec: "cmake"
21+
- spec: cmake@3.23.0
2222
prefix: /usr
2323
buildable: False
2424
mpich:
2525
externals:
26-
- spec: "mpich"
26+
- spec: mpich@3.3
2727
prefix: /usr
2828
buildable: False
2929
perl:
3030
externals:
31-
- spec: "perl"
31+
- spec: perl@5.26.1
3232
prefix: /usr
3333
buildable: False
3434
python:
3535
externals:
36-
- spec: "python"
36+
- spec: python@3.8.0
3737
prefix: /usr
3838
buildable: False
3939
all:
40-
target: ['x86_64']
40+
target: [x86_64]
4141
variants: ~fortran
4242
providers:
4343
mpi: [mpich]
@@ -61,3 +61,5 @@ spack:
6161
config:
6262
build_jobs: 2
6363

64+
mirrors:
65+
E4S: https://cache.e4s.io

.github/ci/spack-envs/clangtidy_nopy_ompi_h5_ad1_ad2/spack.yaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,26 +18,26 @@ spack:
1818
variants: ~zfp ~sz ~png ~dataman ~python ~fortran ~ssc ~shared ~bzip2
1919
cmake:
2020
externals:
21-
- spec: "cmake"
21+
- spec: cmake@3.23.0
2222
prefix: /usr
2323
buildable: False
2424
openmpi:
2525
externals:
26-
- spec: "openmpi"
26+
- spec: openmpi@2.1.1
2727
prefix: /usr
2828
buildable: False
2929
perl:
3030
externals:
31-
- spec: "perl"
31+
- spec: perl@5.26.1
3232
prefix: /usr
3333
buildable: False
3434
python:
3535
externals:
36-
- spec: "python"
36+
- spec: python@3.8.0
3737
prefix: /usr
3838
buildable: False
3939
all:
40-
target: ['x86_64']
40+
target: [x86_64]
4141
variants: ~fortran
4242
providers:
4343
mpi: [openmpi]
@@ -61,3 +61,5 @@ spack:
6161
config:
6262
build_jobs: 2
6363

64+
mirrors:
65+
E4S: https://cache.e4s.io

.github/ci/spack-envs/gcc5_py36_ompi_h5_ad1_ad2/spack.yaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,26 +18,26 @@ spack:
1818
variants: ~zfp ~sz ~png ~dataman ~python ~fortran ~ssc ~shared ~bzip2
1919
cmake:
2020
externals:
21-
- spec: "cmake"
21+
- spec: cmake@3.23.0
2222
prefix: /usr
2323
buildable: False
2424
openmpi:
2525
externals:
26-
- spec: "openmpi"
26+
- spec: openmpi@2.1.1
2727
prefix: /usr
2828
buildable: False
2929
perl:
3030
externals:
31-
- spec: "perl"
31+
- spec: perl@5.26.1
3232
prefix: /usr
3333
buildable: False
3434
python:
3535
externals:
36-
- spec: "python"
36+
- spec: python@3.6.3
3737
prefix: /usr
3838
buildable: False
3939
all:
40-
target: ['x86_64']
40+
target: [x86_64]
4141
variants: ~fortran
4242
compiler: [[email protected]]
4343

@@ -59,3 +59,5 @@ spack:
5959
config:
6060
build_jobs: 2
6161

62+
mirrors:
63+
E4S: https://cache.e4s.io

0 commit comments

Comments
 (0)