Some Pip Tests Fail for 0.15.0-dev

[ax3l]

To be solved before release is tagged:
https://dev.azure.com/axelhuebl/openPMD-api/_build/latest?definitionId=1&branchName=azure_install

[franzpoeschel]

Ubuntu Spack:

==> Installing openpmd-api-0.14.5-dj23dhgaucotxiwtamqsqkxshmupmqze
…
--2023-01-16 01:08:56--  https://raw.githubusercontent.com/openPMD/openPMD-api/dev/examples/3_write_serial.cpp
…
[ 50%] Building CXX object CMakeFiles/mytest.dir/main.cpp.o
/home/vsts/work/1/s/main.cpp: In function ‘int main(int, char**)’:
/home/vsts/work/1/s/main.cpp:52:42: error: no matching function for call to ‘determineDatatype(double*)’
   52 |     Datatype datatype = determineDatatype(global_data.data());
      |                         ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /home/vsts/work/1/s/spack/opt/spack/linux-ubuntu22.04-haswell/gcc-9.5.0/openpmd-api-0.14.5-dj23dhgaucotxiwtamqsqkxshmupmqze/include/openPMD/Dataset.hpp:23,
                 from /home/vsts/work/1/s/spack/opt/spack/linux-ubuntu22.04-haswell/gcc-9.5.0/openpmd-api-0.14.5-dj23dhgaucotxiwtamqsqkxshmupmqze/include/openPMD/openPMD.hpp:29,
                 from /home/vsts/work/1/s/main.cpp:21:
/home/vsts/work/1/s/spack/opt/spack/linux-ubuntu22.04-haswell/gcc-9.5.0/openpmd-api-0.14.5-dj23dhgaucotxiwtamqsqkxshmupmqze/include/openPMD/Datatype.hpp:121:27: note: candidate: ‘template<class T> constexpr openPMD::Datatype openPMD::determineDatatype()’
  121 | inline constexpr Datatype determineDatatype()
      |                           ^~~~~~~~~~~~~~~~~
/home/vsts/work/1/s/spack/opt/spack/linux-ubuntu22.04-haswell/gcc-9.5.0/openpmd-api-0.14.5-dj23dhgaucotxiwtamqsqkxshmupmqze/include/openPMD/Datatype.hpp:121:27: note:   template argument deduction/substitution failed:
/home/vsts/work/1/s/main.cpp:52:42: note:   candidate expects 0 arguments, 1 provided
   52 |     Datatype datatype = determineDatatype(global_data.data());
      |                         ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /home/vsts/work/1/s/spack/opt/spack/linux-ubuntu22.04-haswell/gcc-9.5.0/openpmd-api-0.14.5-dj23dhgaucotxiwtamqsqkxshmupmqze/include/openPMD/Dataset.hpp:23,
                 from /home/vsts/work/1/s/spack/opt/spack/linux-ubuntu22.04-haswell/gcc-9.5.0/openpmd-api-0.14.5-dj23dhgaucotxiwtamqsqkxshmupmqze/include/openPMD/openPMD.hpp:29,
                 from /home/vsts/work/1/s/main.cpp:21:
/home/vsts/work/1/s/spack/opt/spack/linux-ubuntu22.04-haswell/gcc-9.5.0/openpmd-api-0.14.5-dj23dhgaucotxiwtamqsqkxshmupmqze/include/openPMD/Datatype.hpp:273:27: note: candidate: ‘template<class T> constexpr openPMD::Datatype openPMD::determineDatatype(std::shared_ptr<_Tp>)’
  273 | inline constexpr Datatype determineDatatype(std::shared_ptr<T>)
      |                           ^~~~~~~~~~~~~~~~~
/home/vsts/work/1/s/spack/opt/spack/linux-ubuntu22.04-haswell/gcc-9.5.0/openpmd-api-0.14.5-dj23dhgaucotxiwtamqsqkxshmupmqze/include/openPMD/Datatype.hpp:273:27: note:   template argument deduction/substitution failed:
/home/vsts/work/1/s/main.cpp:52:42: note:   mismatched types ‘std::shared_ptr<_Tp>’ and ‘double*’
   52 |     Datatype datatype = determineDatatype(global_data.data());
      |                         ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
gmake[2]: *** [CMakeFiles/mytest.dir/build.make:76: CMakeFiles/mytest.dir/main.cpp.o] Error 1

This builds the dev examples against the release API and then fails because the example uses new APIs??

Most others seem to be import / module-not-found issues

[franzpoeschel]

If the above is supposed to be a compatibility test, shouldn't we use the old examples and compile them against the new library?

[ax3l]

Breaking API is ok, as long as it's documented in NEWS.rst and we update the CI test.