build error against rpm 6.0.0

[ametzler]

libzypp FTBFS against rpm 6.0.0 with

[ 17%] Building CXX object zypp/zypp/CMakeFiles/zypp-objlib.dir/__/__/zypp-logic/zypp/misc/CheckAccessDeleted.cc.o
cd /tmp/ZYPP/libzypp.git/obj-x86_64-linux-gnu/zypp/zypp && /usr/lib/ccache/c++ -DDEBIAN -DHAVE_LIBXML2_XMLCTXTSETERRORHANDLER -DHAVE_PIPE2 -DHAVE_UDEV -DLIBSOLV_SOLVABLE_PREPEND_DEP -DNDEBUG -DWITH_LIBPROXY_SUPPORT -DZYPP_DLL -DZYPP_NDEBUG -DZYPP_RPM_BINARY=\"/usr/libexec/zypp/zypp-rpm\" -DZYPP_WORKER_PATH=\"/usr/libexec/zypp/workers\" -D_FILE_OFFSET_BITS=64 -D_RPM_5 -I/tmp/ZYPP/libzypp.git/zypp -I/tmp/ZYPP/libzypp.git/obj-x86_64-linux-gnu/zypp -I/tmp/ZYPP/libzypp.git/zypp-logic -I/usr/include/rpm -I/usr/include/libxml2 -I/usr/include/sigc++-2.0 -I/usr/lib/x86_64-linux-gnu/sigc++-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -g -O2 -ffile-prefix-map=/tmp/ZYPP/libzypp.git=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -std=c++17 -fPIC -rdynamic -Wl,--no-allow-shlib-undefined -Wl,--no-undefined -Werror=format-security -pthread -fno-strict-aliasing -g -Wall -Wp,-D_GLIBCXX_ASSERTIONS -fvisibility-inlines-hidden -Woverloaded-virtual -Wnon-virtual-dtor -ftemplate-backtrace-limit=0 -Wl,-as-needed -O2 -DZYPP_BASE_LOGGER_LOGGROUP=\"zypp\" -MD -MT zypp/zypp/CMakeFiles/zypp-objlib.dir/__/__/zypp-logic/zypp/misc/CheckAccessDeleted.cc.o -MF CMakeFiles/zypp-objlib.dir/__/__/zypp-logic/zypp/misc/CheckAccessDeleted.cc.o.d -o CMakeFiles/zypp-objlib.dir/__/__/zypp-logic/zypp/misc/CheckAccessDeleted.cc.o -c /tmp/ZYPP/libzypp.git/zypp-logic/zypp/misc/CheckAccessDeleted.cc
In file included from /tmp/ZYPP/libzypp.git/zypp-logic/zypp/target/rpm/BinHeader.h:28,
                 from /tmp/ZYPP/libzypp.git/zypp-logic/zypp/target/rpm/RpmHeader.h:19,
                 from /tmp/ZYPP/libzypp.git/zypp-logic/zypp/target/rpm/librpmDb.h:21,
                 from /tmp/ZYPP/libzypp.git/zypp-logic/zypp/misc/CheckAccessDeleted.cc:28:
/tmp/ZYPP/libzypp.git/zypp-logic/zypp/target/rpm/librpm.h:17:10: fatal error: rpm/rpm4compat.h: No such file or directory
   17 | #include <rpm/rpm4compat.h>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.

[mlandres]

It builds -D_RPM_5 if RPM_LIB_VER VERSION_GREATER_EQUAL "5.0.0".

There should be a "Detected RPM version is:... message from your cmake call . If says 6.0.0, It can be fixed easily.
However I don't know whether there are incompatibilities between rpm4 and rpm6. In this case we'd need to find an rpm6 and test it.

[ametzler]

Thank you.
This builds successfully against rpm 6. One test fails, though (RpmPkgSigCheck).
This is on Debian/sid.

[mlandres]

Thanks for the heads up. RpmPkgSigCheck is something we have to check.