Implement fallback for package name to the recipename

Author: mohamed-rekiba

Build/Rpm.pm

@@ -1322,6 +1322,11 @@ sub parse {
       $$nfbline = [$$nfbline, undef ];
     }
   }
+
+  # if the name is missing or starts with a '%' (probably caused by an unknown macro),
+  # fall back to the recipename.
+  $ret->{'name'} = $1 if (!$ret->{'name'} || $ret->{'name'} =~ /^\%/) && ($options{'recipename'} || '') =~ /(.*)\.spec$/;
+
   unshift @subpacks, $ret->{'name'} if defined $ret->{'name'};
   $ret->{'subpacks'} = \@subpacks;
   $ret->{'exclarch'} = $exclarch if $exclarch;
@@ -1334,9 +1339,6 @@ sub parse {
   $ret->{'moveassets'} = [ map {"$_/$moveassets{$_}"} sort keys %moveassets] if %moveassets;
   $ret->{'dirassets'} = [ sort keys %dirassets ] if %dirassets;
   do_warn($config, "unterminated if/ifarch/ifos statement") if $skip && $config->{'parsing_config'};
-  # if the name starts with a '%' it's probably caused by an unknown macro.
-  # in that case fall back to the recipename.
-  $ret->{'name'} = $1 if ($ret->{'name'} || '') =~ /^\%/ && ($options{'recipename'} || '') =~ /(.*)\.spec$/;
   return $ret;
 }
 

t/parse_spec.t

@@ -1,7 +1,7 @@
 #!/usr/bin/perl -w
 
 use strict;
-use Test::More tests => 19;
+use Test::More tests => 22;
 
 use Build;
 use Build::Rpm;
@@ -495,3 +495,83 @@ $expected = {
 };
 $result = Build::Rpm::parse($conf, [ split("\n", $spec) ]);
 is_deeply($result, $expected, "option macros with negation");
+
+# Test filename fallback when Name: tag is missing
+$spec = q{
+Version: 1.0
+Release: 1
+BuildRequires: foo
+};
+$expected = {
+  'name' => 'test-package',
+  'version' => '1.0',
+  'release' => '1',
+  'deps' => [ 'foo' ],
+  'subpacks' => [ 'test-package' ],
+};
+$result = Build::Rpm::parse($conf, [ split("\n", $spec) ], 'recipename' => 'test-package.spec');
+is_deeply($result, $expected, "filename fallback for missing Name tag");
+
+# Test filename fallback when Name: tag contains unresolved macro
+$spec = q{
+Name: %{undefined_macro}
+Version: 1.0
+Release: 1
+BuildRequires: bar
+};
+$expected = {
+  'name' => 'my-package',
+  'version' => '1.0',
+  'release' => '1',
+  'deps' => [ 'bar' ],
+  'subpacks' => [ 'my-package' ],
+};
+$result = Build::Rpm::parse($conf, [ split("\n", $spec) ], 'recipename' => 'my-package.spec');
+is_deeply($result, $expected, "filename fallback for macro-based Name tag");
+
+# Test rpmautospec-style spec file (similar to vazirmatn-fonts.spec)
+$spec = q{
+## START: Set by rpmautospec
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 10;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
+Version: 33.003
+Release: %autorelease
+URL: https://example.com/project
+
+%global fontlicense OFL-1.1
+%global common_description A test font package
+
+Source0: https://example.com/release/v%{version}/font-v%{version}.zip
+
+%prep
+%setup -q -c
+
+%build
+# Build commands here
+
+%install
+# Install commands here
+
+%files
+# File list here
+
+%changelog
+# Generated by rpmautospec
+};
+$expected = {
+  'name' => 'vazirmatn-fonts',
+  'version' => '33.003',
+  'release' => '%{lua:',
+  'url' => 'https://example.com/project',
+  'source0' => 'https://example.com/release/v33.003/font-v33.003.zip',
+  'deps' => [],
+  'subpacks' => [ 'vazirmatn-fonts' ],
+};
+$result = Build::Rpm::parse($conf, [ split("\n", $spec) ], 'recipename' => 'vazirmatn-fonts.spec');
+is_deeply($result, $expected, "rpmautospec-style spec file with filename fallback");