Merge pull request #18947 from eduardoj/refactoring/backend_api_source_package

Refactor package controller calls to backend using `Backend::Api`

Author: eduardoj

src/api/app/controllers/source_package_controller.rb

@@ -20,14 +20,10 @@ def show
 
     show_package_issues && return if params[:view] == 'issues'
 
-    # exec
-    path = request.path_info
-    path += build_query_from_hash(params, %i[rev linkrev emptylink
-                                             expand view extension
-                                             lastworking withlinked meta
-                                             deleted parse arch
-                                             repository product nofilename])
-    pass_to_backend(path)
+    backend_params = params.slice(*%i[rev linkrev emptylink deleted expand view extension lastworking withlinked meta product
+                                      parse repository arch]).permit!.to_h
+
+    render xml: Backend::Api::Sources::Package.files(@target_project_name, @target_package_name, backend_params)
   end
 
   # DELETE /source/:project/:package
@@ -61,22 +57,14 @@ def delete
   def show_file
     project_name = params[:project]
     package_name = params[:package] || '_project'
-    file = params[:filename]
 
     if params.key?(:deleted)
       if package_name == '_project'
         validate_read_access_of_deleted_project(project_name)
-        pass_to_backend
-        return
+      else
+        validate_read_access_of_deleted_package(project_name, package_name)
       end
-
-      validate_read_access_of_deleted_package(project_name, package_name)
-      pass_to_backend
-      return
-    end
-
-    # a readable package, even on remote instance is enough here
-    if package_name == '_project'
+    elsif package_name == '_project' # a readable package, even on remote instance is enough here
       Project.get_by_name(project_name)
     else
       pack = Package.get_by_project_and_name(project_name, package_name)
@@ -87,9 +75,9 @@ def show_file
       end
     end
 
-    path = Package.source_path(project_name, package_name, file)
-    path += build_query_from_hash(params, %i[rev meta deleted limit expand view])
-    pass_to_backend(path)
+    backend_params = params.slice(*%i[rev meta deleted limit expand view]).permit!.to_h
+
+    send_data(Backend::Api::Sources::File.content(project_name, package_name, params[:filename], backend_params))
   end
 
   # PUT /source/:project/:package/:filename

src/api/app/lib/backend/api/sources/file.rb

@@ -8,7 +8,7 @@ module File
         # Returns the content of the source file
         # @return [String]
         def self.content(project_name, package_name, file_name, options = {})
-          http_get(['/source/:project/:package/:filename', project_name, package_name, file_name], params: options, accepted: %i[deleted expand meta rev view])
+          http_get(['/source/:project/:package/:filename', project_name, package_name, file_name], params: options, accepted: %i[deleted expand meta rev view limit])
         end
 
         # Returns the content of the source file

src/api/app/lib/backend/api/sources/package.rb

@@ -28,7 +28,8 @@ def self.write_attributes(project_name, package_name, user_login, content)
         # @param options [Hash] Parameters to pass to the backend.
         # @return [String]
         def self.files(project_name, package_name, options = {})
-          http_get(['/source/:project/:package', project_name, package_name], params: options, accepted: %i[expand rev view])
+          accepted = %i[rev linkrev emptylink deleted expand view extension lastworking withlinked meta product parse repository arch]
+          http_get(['/source/:project/:package', project_name, package_name], params: options, accepted: accepted)
         end
 
         # Returns a file list of the products for a package